Skip to content

Commit cce084e

Browse files
LeviYeoReummergify[bot]
authored andcommitted
ArmPkg/Include: fix usage of wrong macro in ArmGicv3Dxe
To get a SPI_MAX_INTID, interrupt controller type Register should be masked with ARM_GIC_ICDICTR_GET_SPI_RANGE. However, since ARM_GIC_ICDICTR_SPI_RANGE_TO_MAX_INTID macro uses ARM_GIC_ICDICTR_GET_EXT_SPI_RANGE mask, it returns wrong SPI_MAX_INITID. This makes a failure of loading GenericWatchDog in FVP RevC model. Signed-off-by: Yeoreum Yun <[email protected]> Fixes: d6d2f68 ("ArmPkg/Drivers/ArmGicDxe: ...")
1 parent 215ed37 commit cce084e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

ArmPkg/Include/Library/ArmGicLib.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747

4848
// Extracts the maximum SPI IntId from TypeReg.
4949
#define ARM_GIC_ICDICTR_GET_SPI_MAX_INTID(TypeReg) \
50-
ARM_GIC_ICDICTR_SPI_RANGE_TO_MAX_INTID(ARM_GIC_ICDICTR_GET_EXT_SPI_RANGE(TypeReg))
50+
ARM_GIC_ICDICTR_SPI_RANGE_TO_MAX_INTID(ARM_GIC_ICDICTR_GET_SPI_RANGE(TypeReg))
5151

5252
#define ARM_GIC_ICDICTR_EXT_SPI_ENABLED (1 << 8) // Extended SPI enabled bit.
5353
#define ARM_GIC_ICDICTR_EXT_SPI_RANGE_SHIFT (27) // Extended SPI range position.

0 commit comments

Comments
 (0)