fix(android): release module contexts on dispose

Author: garymathews

Diff for: android/runtime/v8/src/native/KrollNativeBindings.gperf

@@ -12,7 +12,7 @@ namespace titanium {
 struct BindEntry;
 %%
 natives, KrollBindings::initNatives, NULL
-evals, EvaluateModule::Initialize, NULL
+evals, EvaluateModule::Initialize, EvaluateModule::Dispose
 assets, AssetsModule::Initialize, NULL
 API, APIModule::Initialize, APIModule::Dispose
 Titanium, KrollBindings::initTitanium, KrollBindings::disposeTitanium

Diff for: android/runtime/v8/src/native/modules/EvaluateModule.cpp

@@ -67,12 +67,20 @@ namespace titanium {
 		SetMethod(context, isolate, target, "runAsModule", EvaluateModule::RunAsModule);
 	}
 
+	void EvaluateModule::Dispose(Isolate *isolate)
+	{
+		for (auto persistentModuleContext : EvaluateModule::module_contexts) {
+			persistentModuleContext.Reset();
+		}
+		EvaluateModule::module_contexts.clear();
+	}
+
 	void EvaluateModule::GlobalSetterCallback(Local<String> key, Local<Value> value, const PropertyCallbackInfo<Value>& info)
 	{
 		Isolate* isolate = info.GetIsolate();
 
 		// Iterate through current module contexts.
-		for (const auto persistentModuleContext : EvaluateModule::module_contexts) {
+		for (auto persistentModuleContext : EvaluateModule::module_contexts) {
 
 			if (!persistentModuleContext.IsEmpty()) {
 

Diff for: android/runtime/v8/src/native/modules/EvaluateModule.h

@@ -15,8 +15,9 @@ namespace titanium {
 	class EvaluateModule {
 		public:
 			static void Initialize(Local<Object> target, Local<Context> context);
-			static void GlobalSetterCallback(Local<String> key, Local<Value> value, const PropertyCallbackInfo<Value>& info);
+			static void Dispose(Isolate* isolate);
 
+			static void GlobalSetterCallback(Local<String> key, Local<Value> value, const PropertyCallbackInfo<Value>& info);
 			static MaybeLocal<Module> ModuleCallback(Local<Context> context, Local<String> specifier, Local<Module> referrer);
 
 			static void RunAsModule(const FunctionCallbackInfo<Value> &args);