refactor: avoid falsy values and try/catch (#1)

Author: zoey

.gitignore

@@ -66,7 +66,8 @@ vite.config.ts.timestamp-*
 
 # bun
 /.bun/
+/dist/
 
 # Coding agents
 CLAUDE.md
-.claude/
+.claude/

bun.lock

@@ -3,83 +3,68 @@
 
 import { program } from 'commander';
 import chalk from 'chalk';
+import { tools, getDocs, getSourcePath } from '../tools';
 import { TidewaveExtractor } from '../index';
+import { isExtractError, isResolveError } from '../core';
+
+import { name, version } from '../../package.json';
 
 // CLI Interface
 program
-  .name('tidewave')
+  .name(name)
   .description('Universal documentation and source extraction tool for TypeScript and JavaScript')
-  .version('0.1.0');
+  .version(version);
 
-program
-  .command('docs')
-  .description('Extract documentation for a symbol')
-  .argument(
-    '<module-path>',
-    'Module path formats:\n' +
-      '  - module:symbol         - Extract a top-level symbol\n' +
-      '  - module:Class#method   - Extract an instance method\n' +
-      '  - module:Class.method   - Extract a static method\n' +
-      '  - node:Class#method     - Extract a global/builtin instance method\n' +
-      '  - node:Class.method     - Extract a global/builtin static method\n' +
-      '\n' +
-      'Examples:\n' +
-      '  - src/types.ts:SymbolInfo\n' +
-      '  - ./utils:parseConfig\n' +
-      '  - lodash:isEmpty\n' +
-      '  - react:Component#render\n' +
-      '  - Math:Math.max',
-  )
-  .option('-c, --config <path>', 'Path to tsconfig.json')
-  .option('-j, --json', 'Output as JSON')
-  .action(async (modulePath: string, options) => {
-    try {
-      const docs = await TidewaveExtractor.extractDocs(modulePath, {
-        tsConfigPath: options.config,
-      });
+async function handleGetDocs(
+  modulePath: string,
+  options: { config?: string; json?: boolean },
+): Promise<void> {
+  const docsResult = await getDocs(modulePath, { config: options.config });
+
+  if (isExtractError(docsResult)) {
+    console.error(chalk.red(`Error: ${docsResult.error.message}`));
+    process.exit(1);
+  }
+
+  if (options.json) {
+    console.log(JSON.stringify(docsResult, null, 2));
+  } else {
+    console.log(TidewaveExtractor.formatOutput(docsResult));
+  }
+}
 
-      if (docs) {
-        if (options.json) {
-          console.log(JSON.stringify(docs, null, 2));
-        } else {
-          console.log(TidewaveExtractor.formatOutput(docs));
-        }
-      } else {
-        process.exit(1);
-      }
-    } catch (error) {
-      console.error(chalk.red(`Error: ${error instanceof Error ? error.message : String(error)}`));
-      process.exit(1);
-    }
-  });
+async function handleGetSourcePath(
+  moduleName: string,
+  options: { config?: string },
+): Promise<void> {
+  const sourceResult = await getSourcePath(moduleName, { config: options.config });
+
+  if (isResolveError(sourceResult)) {
+    console.error(chalk.red(`Error: ${sourceResult.error.message}`));
+    process.exit(1);
+  }
+
+  console.log(sourceResult.path);
+}
+const {
+  docs: { cli: docsCli },
+  source: { cli: sourceCli },
+} = tools;
+
+program
+  .command(docsCli.command)
+  .description(docsCli.description)
+  .argument(docsCli.argument, docsCli.argumentDescription)
+  .option(docsCli.options.config!.flag, docsCli.options.config!.desc)
+  .option(docsCli.options.json!.flag, docsCli.options.json!.desc)
+  .action(handleGetDocs);
 
 program
-  .command('source')
-  .description('Get the source file path for a module')
-  .argument(
-    '<module>',
-    'Module name to resolve:\n' +
-      '  - Local files: src/utils, ./types.ts, ../config\n' +
-      '  - Dependencies: lodash, react, @types/node\n' +
-      '  - Relative paths: ./src/components/Button',
-  )
-  .option('-c, --config <path>', 'Path to tsconfig.json')
-  .action(async (moduleName: string, options) => {
-    try {
-      const sourcePath = await TidewaveExtractor.getSourcePath(moduleName, {
-        tsConfigPath: options.config,
-      });
+  .command(sourceCli.command)
+  .description(sourceCli.description)
+  .argument(sourceCli.argument, sourceCli.argumentDescription)
+  .option(sourceCli.options.config!.flag, sourceCli.options.config!.desc)
 
-      if (sourcePath) {
-        console.log(sourcePath);
-      } else {
-        process.exit(1);
-      }
-    } catch (error) {
-      console.error(chalk.red(`Error: ${error instanceof Error ? error.message : String(error)}`));
-      process.exit(1);
-    }
-  });
+  .action(handleGetSourcePath);
 
-// Entry point
 program.parse(process.argv);

src/cli/index.ts

@@ -18,6 +18,12 @@ export interface ResolvedModule {
   readonly content?: string;
 }
 
+// Internal type for module resolution with TypeScript program
+export interface InternalResolvedModule {
+  readonly sourceFile: ts.SourceFile;
+  readonly program: ts.Program;
+}
+
 export interface ExtractionRequest {
   readonly module: string;
   readonly symbol: string;
@@ -65,13 +71,16 @@ export interface ExtractError {
 
 export type ResolveResult = ResolvedModule | ResolveError;
 export type ExtractResult = SymbolInfo | ExtractError;
+export type InternalResolveResult = InternalResolvedModule | ResolveError;
 
 export function isError(result: ResolveResult | ExtractResult): boolean {
   return result != null && 'success' in result && result.success === false;
 }
 
-export function isResolveError(result: ResolveResult): result is ResolveError {
-  return isError(result);
+export function isResolveError(
+  result: ResolveResult | InternalResolveResult,
+): result is ResolveError {
+  return result != null && 'success' in result && result.success === false;
 }
 
 export function isExtractError(result: ExtractResult): result is ExtractError {