import NodeSDK conditionally for webpack support, closes #43

Author: josevalim

README.md

@@ -135,35 +135,34 @@ directory of the project (or inside `src` folder if using one):
 
 ```typescript
 // instrumentation.ts
-import { NodeSDK } from '@opentelemetry/sdk-node';
 import type { SpanProcessor } from '@opentelemetry/sdk-trace-base';
 import type { LogRecordProcessor } from '@opentelemetry/sdk-logs';
 
 export async function register() {
-  const runtime = process.env.NEXT_RUNTIME;
-  const env = process.env.NODE_ENV;
-
-  // Add your app own processes here existing configuration
-  const sdkConfig: {
-    spanProcessors: SpanProcessor[];
-    logRecordProcessors: LogRecordProcessor[];
-  } = {
-    spanProcessors: [],
-    logRecordProcessors: [],
-  };
-
-  // Conditionally add Tidewave processors in development
-  if (runtime === 'nodejs' && env === 'development') {
-    const { TidewaveSpanProcessor, TidewaveLogRecordProcessor } = await import(
-      'tidewave/next-js/instrumentation'
-    );
-
-    sdkConfig.spanProcessors.push(new TidewaveSpanProcessor());
-    sdkConfig.logRecordProcessors.push(new TidewaveLogRecordProcessor());
+  if (process.env.NEXT_RUNTIME === 'nodejs') {
+    const { NodeSDK } = await import('@opentelemetry/sdk-node');
+
+    // Add your app own processes here existing configuration
+    const sdkConfig: {
+      spanProcessors: SpanProcessor[];
+      logRecordProcessors: LogRecordProcessor[];
+    } = {
+      spanProcessors: [],
+      logRecordProcessors: [],
+    };
+
+    // Conditionally add Tidewave processors in development
+    if (process.env.NODE_ENV === 'development') {
+      const { TidewaveSpanProcessor, TidewaveLogRecordProcessor } =
+        await import('tidewave/next-js/instrumentation');
+
+      sdkConfig.spanProcessors.push(new TidewaveSpanProcessor());
+      sdkConfig.logRecordProcessors.push(new TidewaveLogRecordProcessor());
+    }
+
+    const sdk = new NodeSDK(sdkConfig);
+    sdk.start();
   }
-
-  const sdk = new NodeSDK(sdkConfig);
-  sdk.start();
 }
 ```
 

src/cli/install.ts

@@ -347,36 +347,35 @@ async function createInstrumentation(dir: string, dryRun: boolean): Promise<void
     return;
   }
 
-  const instrumentationContent = `// instrumentation.ts
-import { NodeSDK } from '@opentelemetry/sdk-node';
-import type { SpanProcessor } from '@opentelemetry/sdk-trace-base';
-import type { LogRecordProcessor } from '@opentelemetry/sdk-logs';
+  const instrumentationContent = `import type { SpanProcessor } from "@opentelemetry/sdk-trace-base";
+import type { LogRecordProcessor } from "@opentelemetry/sdk-logs";
 
 export async function register() {
-  const runtime = process.env.NEXT_RUNTIME;
-  const env = process.env.NODE_ENV;
-
-  // Add your app own processes here existing configuration
-  const sdkConfig: {
-    spanProcessors: SpanProcessor[];
-    logRecordProcessors: LogRecordProcessor[];
-  } = {
-    spanProcessors: [],
-    logRecordProcessors: [],
-  };
+  if (process.env.NEXT_RUNTIME === "nodejs") {
+    const { NodeSDK } = await import("@opentelemetry/sdk-node");
+
+    // Add your app own processes here existing configuration
+    const sdkConfig: {
+      spanProcessors: SpanProcessor[];
+      logRecordProcessors: LogRecordProcessor[];
+    } = {
+      spanProcessors: [],
+      logRecordProcessors: [],
+    };
+
+    // Conditionally add Tidewave processors in development
+    if (process.env.NODE_ENV === "development") {
+      const { TidewaveSpanProcessor, TidewaveLogRecordProcessor } = await import(
+        "tidewave/next-js/instrumentation"
+      );
 
-  // Conditionally add Tidewave processors in development
-  if (runtime === 'nodejs' && env === 'development') {
-    const { TidewaveSpanProcessor, TidewaveLogRecordProcessor } = await import(
-      'tidewave/next-js/instrumentation'
-    );
+      sdkConfig.spanProcessors.push(new TidewaveSpanProcessor());
+      sdkConfig.logRecordProcessors.push(new TidewaveLogRecordProcessor());
+    }
 
-    sdkConfig.spanProcessors.push(new TidewaveSpanProcessor());
-    sdkConfig.logRecordProcessors.push(new TidewaveLogRecordProcessor());
+    const sdk = new NodeSDK(sdkConfig);
+    sdk.start();
   }
-
-  const sdk = new NodeSDK(sdkConfig);
-  sdk.start();
 }
 `;