Avoid creating column name with uppercase characters in dbplyr_uncount()
#1603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenjonesuob
changed the title
dbplyr_uncount()
owenjonesuob
force-pushed
the
b-1601-redshift-uncount
branch
from
7a4d9b5 to
abbce87
Compare
Member
|
Thanks for working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set an explicit lowercase name for the summary column, to avoid problems with Redshift case conversion.
Fixes #1601.
We could use any other lowercase name here, if
"max"is likely to cause any kind of problem/ambiguity!