Advance deprecations (#574)

* Remove vroom_altrep_opts() and vroom(altrep_opts =)

Have been deprecated since v1.2.0 (2020-01-13).

* Remove vroom_write(path =)

* Upgrade literal data without `I()` to a deprecate_warn()

* revdepcheck::cloud_check()

* Actually the deprecation really does date back for 1.5.0

1.7.0 is just when we advanced it

Author: jennybc

NAMESPACE

@@ -75,7 +75,6 @@ export(spec)
 export(starts_with)
 export(vroom)
 export(vroom_altrep)
-export(vroom_altrep_opts)
 export(vroom_example)
 export(vroom_examples)
 export(vroom_format)

NEWS.md

@@ -1,5 +1,13 @@
 # vroom (development version)
 
+* The `path` parameter has been removed from `vroom_write()`. This parameter was
+  deprecated in vroom 1.5.0 (2021-06-14) in favor of the `file` parameter (#575).
+
+* The function `vroom_altrep_opts()` and the argument `vroom(altrep_opts =)`
+  have been removed. They were deprecated in favor of `vroom_altrep()` and
+  `altrep =`, respectively, in v1.2.0 (2020-01-13). Also applies to
+  `vroom_fwf(altrep_opts =)` and `vroom_lines(altrep_opts =)` (#575).
+
 * Columns specified as having type "number" (requested via `col_number()` or `"number"` or `'n'`) or "skip" (requested via `col_skip()` or `"skip"` or `_` or `-`) now work in the case where 0 rows of data are parsed (#427, #540, #548).
 
 # vroom 1.6.7

R/path.R

@@ -83,7 +83,7 @@ standardise_path <- function(
   }
 
   if (any(grepl("\n", path))) {
-    lifecycle::deprecate_soft(
+    lifecycle::deprecate_warn(
       "1.5.0",
       "vroom(file = 'must use `I()` for literal data')",
       details = c(

R/vroom.R

@@ -91,7 +91,6 @@
 #' @param altrep Control which column types use Altrep representations,
 #'   either a character vector of types, `TRUE` or `FALSE`. See
 #'   [vroom_altrep()] for for full details.
-#' @param altrep_opts \Sexpr[results=rd, stage=render]{lifecycle::badge("deprecated")}
 #' @param col_select Columns to include in the results. You can use the same
 #'   mini-language as `dplyr::select()` to refer to the columns by name. Use
 #'   `c()` to use more than one selection expression. Although this
@@ -204,7 +203,6 @@ vroom <- function(
   locale = default_locale(),
   guess_max = 100,
   altrep = TRUE,
-  altrep_opts = deprecated(),
   num_threads = vroom_threads(),
   progress = vroom_progress(),
   show_col_types = NULL,
@@ -217,11 +215,6 @@ vroom <- function(
     delim <- "\x01"
   }
 
-  if (!is_missing(altrep_opts)) {
-    deprecate_warn("1.1.0", "vroom(altrep_opts = )", "vroom(altrep = )")
-    altrep <- altrep_opts
-  }
-
   file <- standardise_path(file)
 
   if (!is_ascii_compatible(locale$encoding)) {
@@ -553,19 +546,6 @@ vroom_altrep <- function(which = NULL) {
   structure(out, class = "vroom_altrep")
 }
 
-#' Show which column types are using Altrep
-#'
-#' @description
-#' \Sexpr[results=rd, stage=render]{lifecycle::badge("deprecated")}
-#' This function is deprecated in favor of `vroom_altrep()`.
-#'
-#' @inheritParams vroom_altrep
-#' @export
-vroom_altrep_opts <- function(which = NULL) {
-  deprecate_warn("1.1.0", "vroom_altrep_opts()", "vroom_altrep()")
-  vroom_altrep(which)
-}
-
 altrep_vals <- function() {
   c(
     "none" = 0L,

R/vroom_fwf.R

@@ -37,19 +37,13 @@ vroom_fwf <- function(
   n_max = Inf,
   guess_max = 100,
   altrep = TRUE,
-  altrep_opts = deprecated(),
   num_threads = vroom_threads(),
   progress = vroom_progress(),
   show_col_types = NULL,
   .name_repair = "unique"
 ) {
   verify_fwf_positions(col_positions)
 
-  if (!is_missing(altrep_opts)) {
-    deprecate_warn("1.1.0", "vroom_fwf(altrep_opts = )", "vroom_fwf(altrep = )")
-    altrep <- altrep_opts
-  }
-
   file <- standardise_path(file)
 
   if (!is_ascii_compatible(locale$encoding)) {

R/vroom_lines.R

@@ -20,19 +20,9 @@ vroom_lines <- function(
   skip_empty_rows = FALSE,
   locale = default_locale(),
   altrep = TRUE,
-  altrep_opts = deprecated(),
   num_threads = vroom_threads(),
   progress = vroom_progress()
 ) {
-  if (!is_missing(altrep_opts)) {
-    deprecate_warn(
-      "1.1.0",
-      "vroom_lines(altrep_opts = )",
-      "vroom_lines(altrep = )"
-    )
-    altrep <- altrep_opts
-  }
-
   file <- standardise_path(file)
 
   if (!is_ascii_compatible(locale$encoding)) {

R/vroom_write.R

@@ -18,8 +18,6 @@
 #' @param delim Delimiter used to separate values. Defaults to `\t` to write
 #'   tab separated value (TSV) files.
 #' @param na String used for missing values. Defaults to 'NA'.
-#' @param path `r lifecycle::badge("deprecated")` is no longer supported, use
-#'   `file` instead.
 #' @export
 #' @examples
 #' # If you only specify a file name, vroom_write() will write
@@ -47,17 +45,8 @@ vroom_write <- function(
   escape = c("double", "backslash", "none"),
   bom = FALSE,
   num_threads = vroom_threads(),
-  progress = vroom_progress(),
-  path = deprecated()
+  progress = vroom_progress()
 ) {
-  if (lifecycle::is_present(path)) {
-    file <- path
-    lifecycle::deprecate_soft(
-      when = "1.5.0",
-      what = "vroom_write(file)"
-    )
-  }
-
   input <- x
 
   quote <- match.arg(quote)

_pkgdown.yml

@@ -75,7 +75,6 @@ reference:
     These functions are used as helpers for other functions, or to inspect objects.
   contents:
   - vroom_lines
-  - vroom_altrep_opts
   - vroom_altrep
   - vroom_example
   - vroom_progress

inst/bench/fwf/vroom_no_altrep-dplyr.R

@@ -2,7 +2,7 @@
   library(vroom)
   library(dplyr)
 })
-x <- vroom_fwf(file, fields, col_types = types, altrep_opts = FALSE)
+x <- vroom_fwf(file, fields, col_types = types, altrep = FALSE)
 print(x)
 a <- head(x)
 b <- tail(x)

inst/bench/fwf/vroom_no_altrep-dplyr.tsv

@@ -1,6 +1,6 @@
 exprs	process	real	size	rows	cols	max_memory
 ({ library(vroom) library(dplyr) })	0.08015654499999991	0.08015990257263184	709936880	2342339	37	6397005824
-x <- vroom_fwf(file, fields, col_types = types, altrep_opts = FALSE)	34.306891702	14.682522296905518	709936880	2342339	37	6397005824
+x <- vroom_fwf(file, fields, col_types = types, altrep = FALSE)	34.306891702	14.682522296905518	709936880	2342339	37	6397005824
 print(x)	0.04313145500000104	0.04313325881958008	709936880	2342339	37	6397005824
 a <- head(x)	8.676749999949607e-4	8.692741394042969e-4	709936880	2342339	37	6397005824
 b <- tail(x)	5.269520000013017e-4	5.283355712890625e-4	709936880	2342339	37	6397005824