Lean more into vroom_tempfile() (#598)

* We should use vroom_tempfile() here too

* Make vroom_tempfile() a bit more featureful

* vroom_tempfile() feels like a path utility to me

* Use `pattern`

Might be helpful if we ever find out we're not cleaning up when we mean to

Author: jennybc

R/path.R

@@ -1,3 +1,11 @@
+vroom_tempfile <- function(fileext = "", pattern = "vroom-") {
+  dir <- Sys.getenv("VROOM_TEMP_PATH")
+  if (!nzchar(dir)) {
+    dir <- tempdir()
+  }
+  tempfile(pattern = pattern, tmpdir = dir, fileext = fileext)
+}
+
 is_ascii_compatible <- function(encoding) {
   identical(
     iconv(list(charToRaw("\n")), from = "ASCII", to = encoding, toRaw = TRUE)[[
@@ -24,7 +32,7 @@ reencode_file <- function(file, encoding, call = caller_env()) {
   } else {
     in_con <- file(file[[1]])
   }
-  out_file <- tempfile()
+  out_file <- vroom_tempfile(pattern = "vroom-reencode-file-")
   out_con <- file(out_file)
   convert_connection(in_con, out_con, encoding, "UTF-8")
   withr::defer(unlink(out_file), envir = parent.frame())
@@ -349,7 +357,7 @@ zipfile <- function(path, open = "r") {
 utils::globalVariables("con")
 
 chr_to_file <- function(x, envir = parent.frame()) {
-  out <- tempfile()
+  out <- vroom_tempfile(pattern = "vroom-chr-to-file-")
   con <- file(out, "wb")
   writeLines(sub("\n$", "", x), con, useBytes = TRUE)
   close(con)

R/vroom.R

@@ -464,14 +464,6 @@ vroom_threads <- function() {
   res
 }
 
-vroom_tempfile <- function() {
-  dir <- Sys.getenv("VROOM_TEMP_PATH")
-  if (!nzchar(dir)) {
-    dir <- tempdir()
-  }
-  tempfile(pattern = "vroom-", tmpdir = dir)
-}
-
 #' Show which column types are using Altrep
 #'
 #' `vroom_altrep()` can be used directly as input to the `altrep`