Skip to content

Error handling of n_max=NA could be improved #545

@jfsalzmann

Description

@jfsalzmann

I recently had a hard time debugging that my code made a wrong vroom::vroom() call with an edge case bug on my side where I supplied n_max = NA.

Instead of some error/exception behaviour from vroom, there was an R error thrown from here, line 33

  if (n_max < 0 || is.infinite(n_max)) {
    n_max <- -1
  }

Error in if (condition) { : missing value where TRUE/FALSE needed

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions