chore(test): migrate and refine tests for OTA downloader to follow new test layout#926
Draft
Bodong-Yang wants to merge 2 commits intomainfrom
Draft
chore(test): migrate and refine tests for OTA downloader to follow new test layout#926Bodong-Yang wants to merge 2 commits intomainfrom
Bodong-Yang wants to merge 2 commits intomainfrom
Conversation
…ation Migrate tests/test_otaclient_common/test_downloader.py per Phase 2 of MIGRATION_PLAN.md, splitting it across the unit and integration tiers per the §3 scope rule. test/unit/test_otaclient_common/test_downloader.py (47 cases) covers the pure-logic and mocked-session paths: cache-policy parsing, header injection helpers, ZstdDecompressionAdapter, retry_on_digest_mismatch decorator, Downloader construction (proxy/cookies/force_http/ decompressor lookup), DownloaderPool instance/thread accounting, and downloading_watchdog driven by a mocked clock. test/integration/test_otaclient_common/test_downloader.py (15 cases) exercises the live HTTP server paths: full-corpus and concurrent-pool downloads, PartialDownload/HashVerificationError/404 passthrough, retry-cache-control header injection observed end-to-end, and urllib3 HTTPResponse live access. The corpus generator + ephemeral-port HTTP subprocess fixture move to the subtree-local conftest.py (replaces the hard-coded port 8889 and the fixed sleep(3) startup wait). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
📊 OTA Update Performance Comparison Report
⏱️ Execution Time
|
Bodong-Yang
added
chore
Bodong-Yang
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.