Merge pull request #67 from tighten/adc/default-exclude-files

Move commonly excluded files to DusterConfig

Author: driftingly

app/Support/DusterConfig.php

@@ -12,6 +12,19 @@ class DusterConfig
     public function __construct(
         protected array $config = []
     ) {
+        $this->config['exclude'] = array_merge(
+            $this->config['exclude'] ?? [],
+            [
+                '_ide_helper_actions.php',
+                '_ide_helper_models.php',
+                '_ide_helper.php',
+                '.phpstorm.meta.php',
+                'bootstrap/cache',
+                'build',
+                'node_modules',
+                'storage',
+            ]
+        );
     }
 
     public function get(string $key, mixed $default = null): mixed

app/Support/PhpCsFixer.php

@@ -22,18 +22,8 @@ public static function getFinder(): Finder
     {
         return Finder::create()
             ->notName([
-                '_ide_helper_actions.php',
-                '_ide_helper_models.php',
-                '_ide_helper.php',
-                '.phpstorm.meta.php',
                 '*.blade.php',
             ])
-            ->exclude([
-                'bootstrap/cache',
-                'build',
-                'node_modules',
-                'storage',
-            ])
             ->ignoreDotFiles(true)
             ->ignoreVCS(true);
     }

phpunit.xml.dist

@@ -12,6 +12,9 @@
         <testsuite name="Feature">
             <directory suffix="Test.php">./tests/Feature</directory>
         </testsuite>
+        <testsuite name="Unit">
+            <directory suffix="Test.php">./tests/Unit</directory>
+        </testsuite>
         <testsuite name="Fixer">
             <directory suffix="Test.php">./tests/Fixer</directory>
         </testsuite>

tests/Unit/DusterConfigTest.php

@@ -0,0 +1,59 @@
+<?php
+
+use App\Support\DusterConfig;
+
+it('provides config values', function () {
+    $dusterConfig = new DusterConfig([
+        'paths' => ['path1', 'path2'],
+        'lint' => true,
+        'fix' => false,
+        'using' => ['tlint', 'phpcs', 'php-cs-fixer', 'pint'],
+    ]);
+
+    expect($dusterConfig->get('paths'))->toBe(['path1', 'path2']);
+    expect($dusterConfig->get('lint'))->toBeTrue();
+    expect($dusterConfig->get('fix'))->toBeFalse();
+    expect($dusterConfig->get('using'))->toBe(['tlint', 'phpcs', 'php-cs-fixer', 'pint']);
+});
+
+it('provides default exclude config values', function () {
+    $dusterConfig = new DusterConfig([
+        'paths' => ['path1', 'path2'],
+        'lint' => true,
+        'fix' => false,
+        'using' => ['tlint', 'phpcs', 'php-cs-fixer', 'pint'],
+    ]);
+
+    expect($dusterConfig->get('exclude'))->toBe([
+        '_ide_helper_actions.php',
+        '_ide_helper_models.php',
+        '_ide_helper.php',
+        '.phpstorm.meta.php',
+        'bootstrap/cache',
+        'build',
+        'node_modules',
+        'storage',
+    ]);
+});
+
+it('merges provided exclude with default exclude config values', function () {
+    $dusterConfig = new DusterConfig([
+        'paths' => ['path1', 'path2'],
+        'lint' => true,
+        'fix' => false,
+        'using' => ['tlint', 'phpcs', 'php-cs-fixer', 'pint'],
+        'exclude' => ['vendor'],
+    ]);
+
+    expect($dusterConfig->get('exclude'))->toBe([
+        'vendor',
+        '_ide_helper_actions.php',
+        '_ide_helper_models.php',
+        '_ide_helper.php',
+        '.phpstorm.meta.php',
+        'bootstrap/cache',
+        'build',
+        'node_modules',
+        'storage',
+    ]);
+});