Exclude cached routes with randomly generated names (#370)

* Add failing test

* Filter out cached generated route names

* Remove unused variable

Author: bakerkretzmar

src/Ziggy.php

@@ -87,6 +87,9 @@ public function filter($filters = [], $include = true): self
     private function nameKeyedRoutes()
     {
         [$fallbacks, $routes] = collect(app('router')->getRoutes()->getRoutesByName())
+            ->reject(function ($route) {
+                return Str::startsWith($route->getName(), 'generated::');
+            })
             ->partition(function ($route) {
                 return $route->isFallback;
             });

tests/Unit/RouteCachingTest.php

@@ -0,0 +1,25 @@
+<?php
+
+namespace Tests\Unit;
+
+use Tests\TestCase;
+use Tightenco\Ziggy\Ziggy;
+
+class RouteCachingTest extends TestCase
+{
+    /** @test */
+    public function can_exclude_routes_with_randomly_generated_names()
+    {
+        app('router')->get('users', $this->noop())->name('users');
+        app('router')->get('cached', $this->noop())->name('generated::ZRopaJJwzA27wRLa');
+
+        $expected = [
+            'users' => [
+                'uri' => 'users',
+                'methods' => ['GET', 'HEAD'],
+            ],
+        ];
+
+        $this->assertSame($expected, (new Ziggy)->toArray()['routes']);
+    }
+}

tests/Unit/ZiggyTest.php

@@ -336,7 +336,6 @@ public function can_include_only_middleware_set_in_config()
     /** @test */
     public function can_order_fallback_routes_last()
     {
-        $ziggy = new Ziggy;
         app('router')->fallback($this->noop())->name('fallback');
         app('router')->get('/users', $this->noop())->name('users.index');