Skip to content

Commit

Permalink
retry: Log::create() requires a string
Browse files Browse the repository at this point in the history
As we defaulted to null, we passed null to create(), which fails.
  • Loading branch information
gerryd committed Apr 4, 2023
1 parent 07a5950 commit 86659d1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/Skeleton/Transaction/Retry.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ trait Retry {
* @param string $output
* @param string $next_retry
*/
public function retry($output = null, $next_retry = '+15 minutes') {
public function retry(string $output = '', $next_retry = '+15 minutes') {
if (self::$max_attempts > 0 && $this->retry_attempt >= self::$max_attempts) {
throw new \Exception($output);
}
Expand All @@ -45,7 +45,7 @@ public function retry($output = null, $next_retry = '+15 minutes') {
* @param int $exp
* @param string $unit
*/
public function retry_incremental($output = null, $exp = 2, $unit = 'minutes') {
public function retry_incremental(string $output = '', $exp = 2, $unit = 'minutes') {
if (self::$max_attempts > 0 && $this->retry_attempt >= self::$max_attempts) {
throw new \Exception($output);
}
Expand Down

0 comments on commit 86659d1

Please sign in to comment.