Skip to content

Commit 9058944

Browse files
fix: align FSS logging config with globalConfig pattern
fixing the broken rebase. Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
1 parent eeb079d commit 9058944

File tree

7 files changed

+22
-16
lines changed

7 files changed

+22
-16
lines changed

lib/global-config.nix

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,12 @@ rec {
8484
default = "";
8585
description = "Logging listener address";
8686
};
87+
88+
port = mkOption {
89+
type = types.port;
90+
default = 9999;
91+
description = "Logging listener port";
92+
};
8793
};
8894

8995
server = {

modules/common/logging/fss.nix

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -297,6 +297,8 @@ let
297297
};
298298
in
299299
{
300+
_file = ./fss.nix;
301+
300302
options.ghaf.logging.fss = {
301303
enable = mkOption {
302304
type = types.bool;

modules/microvm/sysvms/adminvm-base.nix

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,7 @@ in
107107

108108
# Logging - from globalConfig
109109
logging = {
110-
inherit (globalConfig.logging) enable;
111-
listener.address = globalConfig.logging.listener.address or "";
110+
inherit (globalConfig.logging) enable listener;
112111
server = {
113112
inherit (globalConfig.logging) enable;
114113
endpoint = globalConfig.logging.server.endpoint or "";

modules/microvm/sysvms/appvm-base.nix

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -173,8 +173,11 @@ in
173173
role = "client";
174174
};
175175

176-
# Logging
177-
logging.client.enable = globalConfig.logging.enable or false;
176+
# Logging - from globalConfig
177+
logging = {
178+
inherit (globalConfig.logging) enable listener;
179+
client.enable = globalConfig.logging.enable or false;
180+
};
178181

179182
# Security
180183
security.fail2ban.enable = globalConfig.development.ssh.daemon.enable or false;

modules/microvm/sysvms/audiovm-base.nix

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,11 @@ in
116116
};
117117

118118
# Logging - from globalConfig
119-
logging.client.enable = globalConfig.logging.enable or false;
119+
logging = {
120+
inherit (globalConfig.logging) enable listener;
121+
client.enable = globalConfig.logging.enable or false;
122+
server.endpoint = globalConfig.logging.server.endpoint or "";
123+
};
120124

121125
security.fail2ban.enable = globalConfig.development.ssh.daemon.enable or false;
122126

@@ -133,13 +137,6 @@ in
133137
managed = hostConfig.users.managed or { };
134138
};
135139

136-
# Logging config - from globalConfig (previously from serviceModules.logging)
137-
logging = {
138-
enable = globalConfig.logging.enable or false;
139-
listener.address = globalConfig.logging.listener.address or "";
140-
server.endpoint = globalConfig.logging.server.endpoint or "";
141-
};
142-
143140
# GIVC configuration - from globalConfig (previously from serviceModules.givc)
144141
givc = {
145142
enable = globalConfig.givc.enable or false;

modules/microvm/sysvms/guivm-base.nix

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -179,10 +179,9 @@ in
179179

180180
# Logging - from globalConfig
181181
logging = {
182-
inherit (globalConfig.logging) enable;
183-
listener.address = globalConfig.logging.listener.address or "";
184-
server.endpoint = globalConfig.logging.server.endpoint or "";
182+
inherit (globalConfig.logging) enable listener;
185183
client.enable = globalConfig.logging.enable or false;
184+
server.endpoint = globalConfig.logging.server.endpoint or "";
186185
};
187186

188187
# Services

modules/microvm/sysvms/netvm-base.nix

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,8 @@ in
125125

126126
# Logging - from globalConfig (includes listener address)
127127
logging = {
128+
inherit (globalConfig.logging) enable listener;
128129
client.enable = globalConfig.logging.enable or false;
129-
listener.address = globalConfig.logging.listener.address or "";
130130
server.endpoint = globalConfig.logging.server.endpoint or "";
131131
};
132132

0 commit comments

Comments
 (0)