docs: cleanup

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>

Author: brianmcgillion

docs/src/content/docs/ghaf/dev/architecture/config-propagation.mdx

@@ -55,7 +55,7 @@ Ghaf now uses `specialArgs` to inject configuration into VM modules:
 When evaluating NixOS modules with `evalModules`, `specialArgs` provides values that are automatically available to all modules:
 
 ```nix
-lib.evalModules {
+lib.nixosSystem {
   specialArgs = {
     # These become function parameters in ALL modules
     globalConfig = { /* ... */ };
@@ -346,7 +346,7 @@ Profiles create the specialArgs when defining VM bases:
   options.ghaf.profiles.laptop-x86.guivmBase = lib.mkOption {
     type = lib.types.unspecified;
     readOnly = true;
-    default = lib.evalModules {
+    default = lib.nixosSystem {
       # This is where specialArgs are created
       specialArgs = lib.ghaf.vm.mkSpecialArgs {
         inherit lib inputs;

docs/src/content/docs/ghaf/dev/architecture/index.mdx

@@ -171,7 +171,7 @@ The following diagram shows how settings flow from host to VM:
 ┌─────────────────────────────────────────────────────────────────┐
 │  PROFILE (modules/profiles/laptop-x86.nix)                       │
 │                                                                  │
-│  guivmBase = lib.evalModules {                                  │
+│  guivmBase = lib.nixosSystem {                                  │
 │    specialArgs = lib.ghaf.vm.mkSpecialArgs {                    │
 │      inherit lib inputs;                                         │
 │      globalConfig = config.ghaf.global-config;  ◄── From host   │

docs/src/content/docs/ghaf/dev/architecture/vm-composition.mdx

@@ -73,10 +73,10 @@ Ghaf uses a three-layer composition pattern:
 
 ## How evalModules Works
 
-The `lib.evalModules` function creates a lazily-evaluated module system:
+The `lib.nixosSystem` function creates a lazily-evaluated module system:
 
 ```nix
-lib.evalModules {
+lib.nixosSystem {
   # Values available to all modules without explicit passing
   specialArgs = {
     inherit lib inputs;
@@ -113,7 +113,7 @@ The `extendModules` function creates a **new** evaluated module set that include
 
 ```nix
 # Start with base
-baseConfig = lib.evalModules {
+baseConfig = lib.nixosSystem {
   specialArgs = { /* ... */ };
   modules = [ ./base.nix ];
 };
@@ -205,7 +205,7 @@ in
     guivmBase = lib.mkOption {
       type = lib.types.unspecified;
       readOnly = true;
-      default = lib.evalModules {
+      default = lib.nixosSystem {
         specialArgs = mkSpecialArgs "gui-vm";
         modules = [
           inputs.self.nixosModules.guivm-base
@@ -319,7 +319,7 @@ ghaf.virtualization.microvm = {
 
 ```nix
 # This works because evaluation is deferred
-guivmBase = lib.evalModules {
+guivmBase = lib.nixosSystem {
   specialArgs = {
     # References host config, but evaluated lazily
     globalConfig = config.ghaf.global-config;
@@ -345,7 +345,7 @@ upstreamGuivmBase  # Still the same
 
 ```nix
 # Test VM config in isolation
-testConfig = lib.evalModules {
+testConfig = lib.nixosSystem {
   specialArgs = {
     globalConfig = lib.ghaf.profiles.debug;
     hostConfig = { vmName = "test-vm"; /* mock data */ };

docs/src/content/docs/ghaf/dev/guides/migration.mdx

@@ -84,7 +84,7 @@ microvm.vms.gui-vm.config = guivmBaseConfiguration // {
 }
 
 # In profile (laptop-x86.nix)
-guivmBase = lib.evalModules {
+guivmBase = lib.nixosSystem {
   specialArgs = lib.ghaf.vm.mkSpecialArgs globalConfig hostConfigGuivm lib;
   modules = [ guivm-base hardwareExtras ];
 };
@@ -115,7 +115,7 @@ ghaf.virtualization.microvm.guivm.extraModules = lib.mkAfter [
 **Modern:**
 ```nix
 # In profile - compose base with hardware modules
-guivmBase = lib.evalModules {
+guivmBase = lib.nixosSystem {
   specialArgs = ...;
   modules = [
     guivm-base
@@ -220,7 +220,7 @@ globalConfigOverrides = lib.ghaf.profiles.debug // {
 **Modern:**
 ```nix
 # In evaluation (profile or target)
-lib.evalModules {
+lib.nixosSystem {
   specialArgs = { inherit inputs lib; };
   modules = [ ./module-a.nix ./module-b.nix ];
 }

docs/src/content/docs/ghaf/dev/library/profiles-api.mdx

@@ -154,23 +154,24 @@ Factory function for creating custom profiles by extending a base profile.
 **Signature:**
 
 ```nix
-mkGlobalConfig :: AttrSet -> AttrSet
-mkGlobalConfig overrides
+mkGlobalConfig :: String -> AttrSet -> AttrSet
+mkGlobalConfig profileName overrides
 ```
 
 **Parameters:**
 
 | Name | Type | Description |
 |------|------|-------------|
-| `overrides` | AttrSet | Values to merge over the debug profile base |
+| `profileName` | String | Base profile to extend: `"debug"`, `"release"`, or `"minimal"` |
+| `overrides` | AttrSet | Values to merge over the base profile |
 
 **Returns:** Complete global configuration attrset.
 
 **Example:**
 
 ```nix
 # Start with debug profile, customize some settings
-ghaf.global-config = lib.ghaf.mkGlobalConfig {
+ghaf.global-config = lib.ghaf.mkGlobalConfig "debug" {
   # Override specific settings
   givc.debug = false;
   development.ssh.daemon.enable = false;
@@ -215,7 +216,7 @@ ghaf.global-config = lib.ghaf.profiles.debug // {
 Use the factory for cleaner customization:
 
 ```nix
-ghaf.global-config = lib.ghaf.mkGlobalConfig {
+ghaf.global-config = lib.ghaf.mkGlobalConfig "debug" {
   # All debug profile defaults applied
   # Just specify overrides:
   features = {
@@ -233,13 +234,13 @@ Create a project-specific profile:
 # In downstream project's lib/profiles.nix
 { lib }:
 {
-  fmoDebug = lib.ghaf.mkGlobalConfig {
+  fmoDebug = lib.ghaf.mkGlobalConfig "debug" {
     # FMO-specific debug settings
     features.yubikey.targetVms = [ "gui-vm" "gcs-vm" ];
     logging.listener.port = 10000;
   };
 
-  fmoRelease = lib.ghaf.profiles.release // {
+  fmoRelease = lib.ghaf.mkGlobalConfig "release" {
     # FMO production overrides
     features.yubikey.targetVms = [ "gui-vm" "gcs-vm" ];
   };