-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Closed
Labels
type/enhancementThe issue or PR belongs to an enhancement.The issue or PR belongs to an enhancement.
Description
Development Task
Encode ts in storage module can benifit from following aspects:
- Compatible with solution of issue: supporting using more efficient format for put/delete requests #12020
- Resolved the rawkv cdc issue, that when propose failed, there may be dead lock in
resolved_ts, which is currently resolved by dead lock detection intikv/components/cdc/src/endpoint.rs
Line 913 in 7824699
fn handle_raw_outlier_regions( - Helpful to implement stale read in rawkv, ref : Stale read for rawkv with read ts rfcs#96.
To implement this, we need three PRs to achieve it:
- Let raw modify interface in storage use scheduler instead of grpc thread, including
raw_put,raw_delete,raw_batch_put,raw_batch_delete,raw_batch_put_atomic,raw_batch_delete_atomic,raw_compare_and_swap_atomic. rawkv: Reuse scheduler worker pool for raw modify command #13286 - Get causal ts from CausalTsProvider and append ts to key in storage, remove pre_propose observer in
CausalObserver. UseConcurrencyManagerto lock on-road key instead of cdc raw lock heap. rawkv: Encode ts to apiv2 key in storage instead of causal observer #13326 - Remove dead lock detection and move to tikv-cdc and raw
resolved_tsrelated code. cdc: Clean rawkv resolved ts code #13496
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
type/enhancementThe issue or PR belongs to an enhancement.The issue or PR belongs to an enhancement.