throwOnError defaults to false, should it be true?

[stefanpenner]

cc @krisselden

[krisselden]

I thought I made it default to true if NODE_ENV=production it is annoying to have the build fail for a typo during development instead of emitting as many files as it can.

[krisselden]

https://github.com/tildeio/broccoli-typescript-compiler/blob/master/src/normalize-options.ts#L49

[krisselden]

I can update it to check EMBER_ENV too, but I wish we'd adopt NODE_ENV

ember-cli/rfcs#109

[rwjblue]

it is annoying to have the build fail for a typo during development instead of emitting as many files as it can

Hmm, throwing wont crash a running ember serve, it will emit the error (and use the custom middleware for showing errors) and it should resume once the error is corrected. There is even a capability to show a codeframe in the output. This is already exactly what happens with Babel and it doesn’t seem onerous / annoying...

[krisselden]

Typing errors are different than babel errors and typescript is better at emitting useable code on error that often you want to inspect on the console to address type errors especially when you are trying to derive the types.

[rwjblue]

Seems like you have thought this through a bit more than me. I still don’t think I agree (maybe just my own ignorance in typescripts ways), but thank you for explaining the reasoning behind it being enabled only for production.