Aborting a transition with queryParams still triggers fireQueryParamDidChange

[jdkahn]

In Ember 3.20.1, I’m running into an issue when aborting a transition that has queryParams. Even though the transition is aborted, if the queryParams are watched by the target route, the current route is refreshed with the queryParams of the new transition. The issue seems to be related to emberjs/ember.js#18683, although in my case I think there is simple solution. The root cause seems to be in getTransitionByIntent of router_js/transition.

router.js/lib/router/router.ts

Line 272 in bedbf4e

this.notifyExistingHandlers(newState, newTransition);

if (!wasTransitioning) {
    this.notifyExistingHandlers(newState, newTransition);          // triggers willTransition hook that holds the transition.abort() call
}
this.fireQueryParamDidChange(newState, queryParamChangelist!);     // not aware that the transition has been aborted

Would it be possible to wrap the fireQueryParamDidChange call in a check if (!newTransition.isAborted) ?

[patrickberkeley]

@jdkahn does #303 describe the same issue you are seeing?

[jdkahn]

@patrickberkeley I don't believe they are the same issue. It appears to me that #303 is talking about when a QP-only transition interrupts an existing transition, and that the old transition should abort. In my case we manually abort a transition with QP, but is not a QP-only transition.