Skip to content

Calling recognize should not affect the transition.from query params for subsequent transitions #337

Open
@chbonser

Description

@chbonser

Calling router.recognize with a URL which matches the current route affects the transition.from.queryParams for subsequent transitions. I've created a PR with a failing test here.

Root cause seems related to the fact that toReadOnlyRouteInfo (source) closes over a WeakMap for ROUTE_INFOS which is then mutated on subsequent calls (including calls from router.recognize). I don't know the original intent here so I'm not sure the solution.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions