Fix all clippy warnings and migrate deprecated set_zoom() calls

- Remove unused lifetime on find_links_connected_to_node
- Suppress too_many_arguments on find_link_at
- Rename CompositeValidator::add() to with() to avoid Add trait confusion
- Migrate set_zoom() to set_viewport() in tests
- Replace unnecessary vec![] with plain arrays in tests
- Fix always-true assertion in scalability test
- Add type_complexity allows on complex tuple fields

Author: tilladam

examples/advanced/src/main.rs

@@ -452,8 +452,8 @@ fn main() {
 
         // Validate link using the new validator framework
         let validator: CompositeValidator<_, LinkData> = CompositeValidator::new()
-            .add(BasicLinkValidator::new(output_type))
-            .add(NoDuplicatesValidator);
+            .with(BasicLinkValidator::new(output_type))
+            .with(NoDuplicatesValidator);
 
             let links_vec: Vec<LinkData> = links.iter().collect();
             match validator.validate(start_pin, end_pin, &cache, &links_vec) {

examples/pin-compatibility/src/main.rs

@@ -227,8 +227,8 @@ fn main() {
             // Create composite validator with basic checks + type compatibility
             let validator: CompositeValidator<SimpleNodeGeometry, LinkData> =
                 CompositeValidator::new()
-                    .add(BasicLinkValidator::new(2)) // 2 = output pin type
-                    .add(TypeCompatibilityValidator);
+                    .with(BasicLinkValidator::new(2)) // 2 = output pin type
+                    .with(TypeCompatibilityValidator);
 
             let links_vec: Vec<LinkData> = links.iter().collect();
             matches!(
@@ -286,8 +286,8 @@ fn main() {
             // Create composite validator with basic checks + type compatibility
             let validator: CompositeValidator<SimpleNodeGeometry, LinkData> =
                 CompositeValidator::new()
-                    .add(BasicLinkValidator::new(2)) // 2 = output pin type
-                    .add(TypeCompatibilityValidator);
+                    .with(BasicLinkValidator::new(2)) // 2 = output pin type
+                    .with(TypeCompatibilityValidator);
 
             let links_vec: Vec<LinkData> = links.iter().collect();
             match validator.validate(start_pin, end_pin, &cache, &links_vec) {

src/graph.rs

@@ -100,7 +100,7 @@ impl GraphLogic {
     /// * `node_id` - The ID of the node being deleted/queried
     /// * `links` - Iterator over the links
     /// * `cache` - Geometry cache to look up pin ownership
-    pub fn find_links_connected_to_node<'a, I, L, N>(
+    pub fn find_links_connected_to_node<I, L, N>(
         node_id: i32,
         links: I,
         cache: &GeometryCache<N>,
@@ -459,8 +459,8 @@ where
 ///
 /// ```ignore
 /// let validator = CompositeValidator::new()
-///     .add(BasicLinkValidator::new(2))
-///     .add(NoDuplicatesValidator);
+///     .with(BasicLinkValidator::new(2))
+///     .with(NoDuplicatesValidator);
 ///
 /// let result = validator.validate(start_pin, end_pin, &cache, &links);
 /// ```
@@ -486,7 +486,7 @@ impl<N, L> CompositeValidator<N, L> {
     ///
     /// Validators are checked in the order they were added.
     /// The first validator to return Invalid will short-circuit.
-    pub fn add<V: LinkValidator<N, L> + 'static>(mut self, validator: V) -> Self {
+    pub fn with<V: LinkValidator<N, L> + 'static>(mut self, validator: V) -> Self {
         self.validators.push(Box::new(validator));
         self
     }
@@ -719,8 +719,8 @@ mod tests {
     fn test_composite_validator_passes_all() {
         let cache = setup_cache();
         let validator: CompositeValidator<_, TestLink> = CompositeValidator::new()
-            .add(BasicLinkValidator::new(2))
-            .add(NoDuplicatesValidator);
+            .with(BasicLinkValidator::new(2))
+            .with(NoDuplicatesValidator);
 
         let links = vec![];
 
@@ -732,8 +732,8 @@ mod tests {
     fn test_composite_validator_short_circuits_on_basic() {
         let cache = setup_cache();
         let validator: CompositeValidator<_, TestLink> = CompositeValidator::new()
-            .add(BasicLinkValidator::new(2))
-            .add(NoDuplicatesValidator);
+            .with(BasicLinkValidator::new(2))
+            .with(NoDuplicatesValidator);
 
         let links = vec![];
 
@@ -746,8 +746,8 @@ mod tests {
     fn test_composite_validator_short_circuits_on_duplicates() {
         let cache = setup_cache();
         let validator: CompositeValidator<_, TestLink> = CompositeValidator::new()
-            .add(BasicLinkValidator::new(2))
-            .add(NoDuplicatesValidator);
+            .with(BasicLinkValidator::new(2))
+            .with(NoDuplicatesValidator);
 
         let links = vec![TestLink {
             id: 1,

src/state.rs

@@ -85,6 +85,7 @@ where
     }
 
     /// Find link at position
+    #[allow(clippy::too_many_arguments)]
     pub fn find_link_at<'a, I>(
         &'a self,
         x: f32,

tests/common/harness.rs

@@ -138,7 +138,7 @@ impl MinimalTestHarness {
             let w = w.clone();
             move |z, pan_x, pan_y| {
                 if let Some(w) = w.upgrade() {
-                    ctrl.set_zoom(z);
+                    ctrl.set_viewport(z, pan_x, pan_y);
                     w.set_grid_commands(ctrl.generate_grid(w.get_width_(), w.get_height_(), pan_x, pan_y));
                     tracker.update_viewport.borrow_mut().push((z, pan_x, pan_y));
                 }

tests/common/mod.rs

@@ -25,8 +25,10 @@ pub struct CallbackTracker {
     /// Count of delete_selected calls
     pub delete_selected: Rc<RefCell<usize>>,
     /// (node_id, x, y, width, height)
+    #[allow(clippy::type_complexity)]
     pub node_rect_changed: Rc<RefCell<Vec<(i32, f32, f32, f32, f32)>>>,
     /// (pin_id, node_id, pin_type, x, y)
+    #[allow(clippy::type_complexity)]
     pub pin_position_changed: Rc<RefCell<Vec<(i32, i32, i32, f32, f32)>>>,
     /// (zoom, pan_x, pan_y)
     pub update_viewport: Rc<RefCell<Vec<(f32, f32, f32)>>>,

tests/level3_links.rs

@@ -273,7 +273,7 @@ fn test_zoom_affects_link_path() {
     let path_zoom_1 = harness.ctrl.compute_link_path(3, 4);
 
     // Change zoom
-    harness.ctrl.set_zoom(2.0);
+    harness.ctrl.set_viewport(2.0, 0.0, 0.0);
     let path_zoom_2 = harness.ctrl.compute_link_path(3, 4);
 
     // Paths should be different due to bezier offset scaling

tests/level5_keyboard.rs

@@ -218,7 +218,7 @@ fn test_deleting_node_should_also_remove_connected_links() {
 
     // Find links connected to node 1
     // Pin IDs for node 1 are: 2 (input) and 3 (output)
-    let node_pins = vec![2, 3]; // node_id * 2 and node_id * 2 + 1
+    let node_pins = [2, 3]; // node_id * 2 and node_id * 2 + 1
 
     // Remove connected links
     let mut links_to_remove = Vec::new();

tests/level6_advanced.rs

@@ -37,10 +37,10 @@ fn test_default_zoom_is_one() {
 fn test_set_zoom() {
     let harness = MinimalTestHarness::new();
 
-    harness.ctrl.set_zoom(1.5);
+    harness.ctrl.set_viewport(1.5, 0.0, 0.0);
     assert_eq!(harness.ctrl.zoom(), 1.5);
 
-    harness.ctrl.set_zoom(0.5);
+    harness.ctrl.set_viewport(0.5, 0.0, 0.0);
     assert_eq!(harness.ctrl.zoom(), 0.5);
 }
 
@@ -51,7 +51,7 @@ fn test_zoom_affects_link_path_calculation() {
 
     let path_at_1x = harness.ctrl.compute_link_path(3, 4);
 
-    harness.ctrl.set_zoom(2.0);
+    harness.ctrl.set_viewport(2.0, 0.0, 0.0);
     let path_at_2x = harness.ctrl.compute_link_path(3, 4);
 
     // Paths should differ due to zoom affecting bezier control points
@@ -68,7 +68,7 @@ fn test_zoom_affects_grid_generation() {
 
     let grid_1x = harness.ctrl.generate_grid(800.0, 600.0, 0.0, 0.0);
 
-    harness.ctrl.set_zoom(2.0);
+    harness.ctrl.set_viewport(2.0, 0.0, 0.0);
     let grid_2x = harness.ctrl.generate_grid(800.0, 600.0, 0.0, 0.0);
 
     assert_ne!(
@@ -302,8 +302,8 @@ fn test_composite_validator() {
     setup_test_geometry(&harness);
 
     let validator = CompositeValidator::new()
-        .add(BasicLinkValidator::new(2))
-        .add(NoDuplicatesValidator);
+        .with(BasicLinkValidator::new(2))
+        .with(NoDuplicatesValidator);
 
     let cache = harness.ctrl.cache();
     let cache = cache.borrow();
@@ -461,7 +461,7 @@ fn test_find_links_connected_to_node() {
     harness.ctrl.cache().borrow_mut().handle_pin_report(7, 3, 2, 150.0, 50.0);
 
     // Find links connected to node 2 (pins 4 and 5)
-    let node2_pins = vec![4, 5];
+    let node2_pins = [4, 5];
     let mut connected = Vec::new();
 
     for i in 0..harness.links.row_count() {

tests/level7_scalability.rs

@@ -687,7 +687,7 @@ fn test_compute_link_path_1k_links() {
 
     for (_, start_pin, end_pin) in &links {
         let path = cache.compute_link_path(*start_pin, *end_pin, 1.0, 50.0);
-        assert!(path.is_some() || true); // Some might be None if pins don't exist
+        let _ = path; // Some might be None if pins don't exist
     }
 
     let elapsed = start.elapsed();