-
Notifications
You must be signed in to change notification settings - Fork 5
Description
I'm not sure what's the recommended way is to use the header files in tkey-libs. To me, it makes most sense to use -I .../tkey-libs/include when compiling apps and libraries for the tkey. Then tkey-specific headers can be used as #include <tkey/debug.h>.
That makes the top-level tkey-libs/include directory a reasonable place for standard C include files that aren't provided by the compiler. I'm missing at least assert.h (which could either just include tkey/assert.h, or have the latter file move up one level), stdlib.h (which at a minimum should declare abort ()), and string.h which should declare standard functions now in tkey/lib.h, as well as additional utilities that are currently missing, e.g., memcmp and strcmp.
Is this a reasonable approach, or do you see a better place for the standard C includes that are currently missing?
One might consider splitting libcommon into one library that is essentially a libc subset, and one library with tkey-specific utilities, but to me it seems good enough to have it all in libcommon.
Related to #51.