describe doesn't work with complex EDITOR command

[hrehfeld]

Quoting issue? jj-fzf is the only tool that's failing in this way.

$ jj-fzf
...
+ jj describe --edit ntk...
Warning: `jj describe --edit` is deprecated; use `jj describe --editor` instead

/usr/libexec/jj-fzf-0.34/lib/editor.sh: line 18: /usr/bin/emacsclient-default-directory -c: No such file or directory
Error: Failed to edit description
Caused by: Editor '/usr/libexec/jj-fzf-0.34/lib/editor.sh' exited with exit status: 127
Hint: Edited description is left in /tmp/editor-9qPk7V.jjdescription

$ jj describe --edit ntk...
Warning: `jj describe --edit` is deprecated; use `jj describe --editor` instead
Waiting for Emacs...
Rebased 1 descendant commits
Working copy  (@) now at: ...
Parent commit (@-)      : ntk...

$ echo $EDITOR 
/usr/bin/emacsclient-default-directory -c

$ ls /usr/bin/emacsclient-default-directory
/usr/bin/emacsclient-default-directory

$ cat ~/.config/shell/env.d/editor.sh 
ec="$(command -v emacsclient-default-directory || command -v emacsclient) -c"
export EDITOR="$ec"
export SUDO_EDITOR="$ec"

$ jj-fzf --version
jj-fzf 0.34.0 2025-10-02 04:08:08 +0200

[hrehfeld]

If I set VISUAL to the same command, it also fails in the same way.

[tim-janik]

Can you check if this patch to lib/editor.sh fixes your problem?

-"$JJ_EDITOR" "$@" || ERR=$?
+$JJ_EDITOR "$@" || ERR=$?

0001-lib-editor.sh-avoid-quoting-EDITOR-which-may-contain.patch

[hrehfeld]

Fixes it! Thanks!