Reassigned/saved bookmark no longer appears in the saved bookmark folder.

[Snake883]

When I reassign and save the bookmark to a different folder (outside of Tabs Aside), the bookmark appears moved into the folder I designated, but the bookmark is deleted after I close the tab.

1. I have a tab that is bookmarked and included in a saved session bookmark folder.
2. I open the bookmark into a new tab.
3. Edit the bookmark and save the tab to another folder outside of Tabs Aside.
4. The bookmark appears in the new bookmark folder as expected.
5. Close the tab.
6. The bookmark no long appears in the new bookmark folder.
7. The bookmark unexpectedly reappears in the Tabs Aside folder.

v3.6.0

I think it has something to do with the Tab Closing behavior. What happens to the bookmark when I save the bookmark to another folder and close the tab?

My guess is Tabs Aside either "removes" the bookmark entirely or moves/ re"set aside" the bookmark to the Tabs Aside session folder.

When the bookmark is moved, then closing the tab should do nothing.

[tim-we]

I must admit that I have not really considered that use case. Bookmarks have a unique id. I assume when you edit the bookmark and change its folder the id stays the same. When the tab gets closed Tabs Aside will just remove the bookmark with that id.

I'll have a look into it. I think it should be possible to check whether the bookmark is still a child of the session folder and only remove it when that is the case. Thanks for letting me know!

[tim-we]

So I have fixed that problem in e54a861 but unfortunately this causes another issue due to the additional delay caused by fetching the bookmark (to verify it is still in the session folder). When you close an active session the session gets removed. This is not intended behavior and has to be avoided. Unfortunately there is no way to detect that a window is closing before the tabs are removed, thats where the race condition comes from.

I assume a proper fix for both issues requires a lot more work, I'll see what I can do but it will take some time and unfortunately I do not have a lot of time for Tabs Aside development. Sorry.