TextRange module's findText fix for text with non-breaking space. #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pburrows
added a commit
to pburrows/rangy-updated
that referenced
this pull request
Jan 2, 2019
|
merged PR here: pburrows/rangy-updated@854b8ad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fix to the TextRange module's findText method to search and match the text when the text in the document contains non-breaking space ( ).
For example, if the document has html "test match with findText", innerText would return "test match with findText". Even though the space looks normal whitespace between "test match", this is decoded character value of . When we search for "test match", textRange.findText wouldn't find match.
According to the documentation, search should be performed on the visible text of the document but not on the decoded characters. Hence I made this change.