Skip to content

Commit 2883494

Browse files
authored
feat(infra): Remove CIDR requirement [CLK-187171] (#5)
1 parent 2b2c7d6 commit 2883494

File tree

4 files changed

+1
-61
lines changed

4 files changed

+1
-61
lines changed

API.md

Lines changed: 0 additions & 48 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Shard.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,4 @@
11
export interface IShardProps {
2-
/**
3-
* The cidr for a shard's vpc.
4-
* Regions typically receive a 10.?.0.0/12 address space,
5-
* within which there are 16 /16 subnets for shards.
6-
*/
7-
readonly cidr: string;
82
/**
93
* The AWS region for a shard.
104
*/
@@ -23,12 +17,10 @@ export interface IShard extends IShardProps {
2317
}
2418

2519
export abstract class Shard implements IShard {
26-
readonly cidr: string;
2720
readonly region: string;
2821
readonly number: number;
2922

3023
constructor(props: IShardProps) {
31-
this.cidr = props.cidr;
3224
this.region = props.region;
3325
this.number = props.number;
3426
}

test/NamedEnv.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ describe('NamedEnv', () => {
5151
};
5252

5353
shard = {
54-
cidr: '10.0.0.0/0',
5554
region: 'us-west-2',
5655
name: 'TestShard',
5756
number: 1,

test/Shard.test.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,14 @@ class TestShardImpl extends Shard {
77
}
88
}
99

10-
const testShardProps: IShardProps = { cidr: '10.0.0.0/0', region: 'us-west-2', number: 1 };
10+
const testShardProps: IShardProps = { region: 'us-west-2', number: 1 };
1111

1212
let shard: IShard;
1313
describe('Shard', () => {
1414
beforeEach(() => {
1515
shard = new TestShardImpl(testShardProps);
1616
});
1717

18-
it('sets CIDR correctly', () => {
19-
expect(shard.cidr).toEqual(testShardProps.cidr);
20-
});
2118
it('sets region correctly', () => {
2219
expect(shard.region).toEqual(testShardProps.region);
2320
});

0 commit comments

Comments
 (0)