You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardexpand all lines: RELEASE.md
+11-7
Original file line number
Diff line number
Diff line change
@@ -6,17 +6,16 @@ Updating the driver from the upstream repo ([ClickHouse](https://github.com/Clic
6
6
7
7
This version of the Timeplus Proton driver is based on [01ecc5fbcc53d007b9a7357bd358428a4f3bc738](https://github.com/ClickHouse/metabase-clickhouse-driver/commit/01ecc5fbcc53d007b9a7357bd358428a4f3bc738) of the upstream driver.
8
8
9
-
A. Start by performing simple text replacements for:
10
-
*`s/ClickHouse/Proton/g` -- proper nouns embedded in documentation and comments
11
-
*`s/:clickhouse/:proton/g` -- keywords
12
-
*`s/clickhouse/proton/g` -- symbols
13
-
14
-
inside the following 4 files:
9
+
There are a total of 4 files that need to be updated:
15
10
1.`src/metabase/driver/proton.clj`
16
11
2.`src/metabase/driver/proton_introspection.clj`
17
12
3.`src/metabase/driver/proton_version.clj`
18
13
4.`src/metabase/driver/proton_qp.clj`
19
14
15
+
A. Start by performing simple text replacements for:
16
+
*`s/ClickHouse/Proton/g` -- proper nouns embedded in documentation and comments
17
+
*`s/:clickhouse/:proton/g` -- keywords
18
+
*`s/clickhouse/proton/g` -- symbols
20
19
21
20
B. The 4th file -- `src/metabase/driver/proton_qp.clj` -- requires additional text replacements.
22
21
@@ -26,7 +25,12 @@ cd metabase-proton-driver/scripts/
26
25
./replace.sh ../src/metabase/driver/proton_qp.clj
27
26
```
28
27
29
-
C. Running the command below should catch any stray errors like unbalanced parentheses or syntax errors:
28
+
C. Note that `src/metabase/driver/proton.clj` and `src/metabase/driver/proton_qp.clj` now hard-code a minimum supported version for Proton. I tested my changes on v1.5.6 so it's currently set to v1.5 in both files.
0 commit comments