Skip to content

Commit 3e28ac1

Browse files
authored
Reorder and add a note on min Proton version (v1.5.6)
1 parent 46550c6 commit 3e28ac1

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

RELEASE.md

+11-7
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,16 @@ Updating the driver from the upstream repo ([ClickHouse](https://github.com/Clic
66

77
This version of the Timeplus Proton driver is based on [01ecc5fbcc53d007b9a7357bd358428a4f3bc738](https://github.com/ClickHouse/metabase-clickhouse-driver/commit/01ecc5fbcc53d007b9a7357bd358428a4f3bc738) of the upstream driver.
88

9-
A. Start by performing simple text replacements for:
10-
* `s/ClickHouse/Proton/g` -- proper nouns embedded in documentation and comments
11-
* `s/:clickhouse/:proton/g` -- keywords
12-
* `s/clickhouse/proton/g` -- symbols
13-
14-
inside the following 4 files:
9+
There are a total of 4 files that need to be updated:
1510
1. `src/metabase/driver/proton.clj`
1611
2. `src/metabase/driver/proton_introspection.clj`
1712
3. `src/metabase/driver/proton_version.clj`
1813
4. `src/metabase/driver/proton_qp.clj`
1914

15+
A. Start by performing simple text replacements for:
16+
* `s/ClickHouse/Proton/g` -- proper nouns embedded in documentation and comments
17+
* `s/:clickhouse/:proton/g` -- keywords
18+
* `s/clickhouse/proton/g` -- symbols
2019

2120
B. The 4th file -- `src/metabase/driver/proton_qp.clj` -- requires additional text replacements.
2221

@@ -26,7 +25,12 @@ cd metabase-proton-driver/scripts/
2625
./replace.sh ../src/metabase/driver/proton_qp.clj
2726
```
2827

29-
C. Running the command below should catch any stray errors like unbalanced parentheses or syntax errors:
28+
C. Note that `src/metabase/driver/proton.clj` and `src/metabase/driver/proton_qp.clj` now hard-code a minimum supported version for Proton. I tested my changes on v1.5.6 so it's currently set to v1.5 in both files.
29+
* [`src/metabase/driver/proton.clj`](https://github.com/ayewo/metabase-proton-driver/blob/46550c6eb8d7e363d9f3a0fb882c5e7185abe38d/src/metabase/driver/proton.clj#L220)
30+
* [`src/metabase/driver/proton_qp.clj`](https://github.com/ayewo/metabase-proton-driver/blob/46550c6eb8d7e363d9f3a0fb882c5e7185abe38d/src/metabase/driver/proton_qp.clj#L391-L398)
31+
32+
33+
D. Running the command below should catch any stray errors like unbalanced parentheses or syntax errors:
3034
```bash
3135
lein check
3236
```

0 commit comments

Comments
 (0)