feat: better default config values

Author: ye11ow

pkg/plugin/datasource.go

@@ -208,6 +208,11 @@ func (d *Datasource) CheckHealth(ctx context.Context, req *backend.CheckHealthRe
 		res.Message = "'Host' cannot be empty"
 		return res, nil
 	}
+	if len(config.Username) == 0 {
+		res.Status = backend.HealthStatusError
+		res.Message = "'Username' cannot be empty"
+		return res, nil
+	}
 
 	engine := timeplus.NewEngine(logger, config.Host, config.TCPPort, config.HTTPPort, config.Username, config.Secrets.Password)
 

pkg/timeplus/engine.go

@@ -37,6 +37,12 @@ type TimeplusEngine struct {
 }
 
 func NewEngine(logger log.Logger, host string, tcpPort, httpPort int, username, password string) *TimeplusEngine {
+	if tcpPort == 0 {
+		tcpPort = 8463
+	}
+	if httpPort == 0 {
+		httpPort = 3218
+	}
 	connection := protonDriver.OpenDB(&protonDriver.Options{
 		Addr: []string{fmt.Sprintf("%s:%d", host, tcpPort)},
 		Auth: protonDriver.Auth{

src/components/ConfigEditor.tsx

@@ -1,8 +1,9 @@
-import React, { ChangeEvent } from 'react';
 import { InlineField, Input, SecretInput } from '@grafana/ui';
-import { DataSourcePluginOptionsEditorProps } from '@grafana/data';
+import React, { ChangeEvent } from 'react';
 import { TpDataSourceOptions, TpSecureJsonData } from '../types';
 
+import { DataSourcePluginOptionsEditorProps } from '@grafana/data';
+
 interface Props extends DataSourcePluginOptionsEditorProps<TpDataSourceOptions, TpSecureJsonData> {}
 
 export function ConfigEditor(props: Props) {
@@ -75,8 +76,9 @@ export function ConfigEditor(props: Props) {
 
   return (
     <>
-      <InlineField label="Host" labelWidth={14} interactive tooltip={'Hostname'}>
+      <InlineField required={true} label="Host" labelWidth={14} interactive tooltip={'Hostname'}>
         <Input
+          required={true}
           id="config-editor-host"
           onChange={onHostChange}
           value={jsonData.host}
@@ -104,8 +106,9 @@ export function ConfigEditor(props: Props) {
           width={40}
         />
       </InlineField>
-      <InlineField label="Username" labelWidth={14} interactive tooltip={'Username'}>
+      <InlineField required={true} label="Username" labelWidth={14} interactive tooltip={'Username'}>
         <Input
+          required={true}
           id="config-editor-username"
           onChange={onUsernameChange}
           value={jsonData.username}