Skip to content

Commit 39e368d

Browse files
authored
Remove host specification from pg_regress temporary instance (#10020)
It has no purpose and leads to TCP port collisions.
1 parent 612452a commit 39e368d

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

test/test-defs.cmake

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,7 @@ file(
7575
NO_SOURCE_PERMISSIONS
7676
FILE_PERMISSIONS OWNER_READ OWNER_WRITE)
7777

78-
set(PG_REGRESS_OPTS_BASE --host=${TEST_PGHOST}
79-
--dlpath=${PROJECT_BINARY_DIR}/src)
78+
set(PG_REGRESS_OPTS_BASE --dlpath=${PROJECT_BINARY_DIR}/src)
8079

8180
set(PG_REGRESS_OPTS_EXTRA
8281
--create-role=${TEST_ROLE_SUPERUSER},${TEST_ROLE_DEFAULT_PERM_USER},${TEST_ROLE_DEFAULT_PERM_USER_2},${TEST_ROLE_1},${TEST_ROLE_2},${TEST_ROLE_3},${TEST_ROLE_4},${TEST_ROLE_READ_ONLY}
@@ -112,7 +111,8 @@ set(PG_REGRESS_OPTS_TEMP_INSTANCE_PGTEST
112111
--port=${TEST_PGPORT_TEMP_INSTANCE} --temp-instance=${TEST_CLUSTER}
113112
--temp-config=${TEST_OUTPUT_DIR}/pgtest.conf)
114113

115-
set(PG_REGRESS_OPTS_LOCAL_INSTANCE --port=${TEST_PGPORT_LOCAL})
114+
set(PG_REGRESS_OPTS_LOCAL_INSTANCE --host=${TEST_PGHOST}
115+
--port=${TEST_PGPORT_LOCAL})
116116

117117
if(PG_REGRESS)
118118
set(PG_REGRESS_ENV

0 commit comments

Comments
 (0)