Merge branch 'main' into fix/artefact_step

Author: surister

.github/gh_matrix_builder.py

@@ -103,7 +103,7 @@ def build_debug_config(overrides):
             "pg_extensions": "postgres_fdw test_decoding",
             "installcheck": True,
             "pginstallcheck": True,
-            "tsdb_build_args": "-DWARNINGS_AS_ERRORS=ON -DREQUIRE_ALL_TESTS=ON",
+            "tsdb_build_args": "-DWARNINGS_AS_ERRORS=ON",
         }
     )
     base_config.update(overrides)
@@ -119,7 +119,7 @@ def build_release_config(overrides):
         {
             "name": "Release",
             "build_type": "RelWithDebInfo",
-            "tsdb_build_args": "-DWARNINGS_AS_ERRORS=ON -DREQUIRE_ALL_TESTS=ON",
+            "tsdb_build_args": "-DWARNINGS_AS_ERRORS=ON",
             "coverage": False,
         }
     )
@@ -145,7 +145,7 @@ def build_apache_config(overrides):
         {
             "name": "ApacheOnly",
             "build_type": "RelWithDebInfo",
-            "tsdb_build_args": "-DWARNINGS_AS_ERRORS=ON -DREQUIRE_ALL_TESTS=ON -DAPACHE_ONLY=1",
+            "tsdb_build_args": "-DWARNINGS_AS_ERRORS=ON -DAPACHE_ONLY=1",
             "coverage": False,
         }
     )
@@ -179,9 +179,7 @@ def macos_config(overrides):
             "pg_extensions": "postgres_fdw test_decoding",
             "pginstallcheck": True,
             "tsdb_build_args": (
-                " -DASSERTIONS=ON"
-                " -DREQUIRE_ALL_TESTS=ON"
-                f" -DOPENSSL_ROOT_DIR={openssl_path}"
+                " -DASSERTIONS=ON" f" -DOPENSSL_ROOT_DIR={openssl_path}"
             ),
         }
     )
@@ -415,19 +413,23 @@ def macos_config(overrides):
 
     if tests:
         to_run = [t for t in list(tests) if t not in flaky_exclude_tests] * 20
-        random.shuffle(to_run)
-        installcheck_args = f'TESTS="{" ".join(to_run)}"'
-        m["include"].append(
-            build_debug_config(
-                {
-                    "coverage": False,
-                    "installcheck_args": installcheck_args,
-                    "name": "Flaky Check Debug",
-                    "pg": PG18_LATEST,
-                    "pginstallcheck": False,
-                }
+        # Skip the Flaky job when every changed test is excluded. Otherwise
+        # TESTS="" makes `make installcheck` run the full suite, which exposes
+        # pre-existing XX000s the per-test loop would never have touched.
+        if to_run:
+            random.shuffle(to_run)
+            installcheck_args = f'TESTS="{" ".join(to_run)}"'
+            m["include"].append(
+                build_debug_config(
+                    {
+                        "coverage": False,
+                        "installcheck_args": installcheck_args,
+                        "name": "Flaky Check Debug",
+                        "pg": PG18_LATEST,
+                        "pginstallcheck": False,
+                    }
+                )
             )
-        )
 
 # generate command to set github action variable
 with open(os.environ["GITHUB_OUTPUT"], "a", encoding="utf-8") as output:

.github/workflows/apt-installcheck.yaml

@@ -44,6 +44,7 @@ jobs:
 
     steps:
     - name: Add repositories
+      timeout-minutes: 15
       run: |
         apt-get update
         apt-get install -y wget lsb-release gnupg sudo postgresql-common git cmake jq
@@ -54,6 +55,7 @@ jobs:
         wget --quiet -O - https://packagecloud.io/timescale/timescaledb/gpgkey | gpg --dearmor -o /etc/apt/trusted.gpg.d/timescale_timescaledb.gpg
 
     - name: Install timescaledb
+      timeout-minutes: 15
       run: |
         apt-get update
         apt-get install -y --no-install-recommends \

.github/workflows/apt-packages.yaml

@@ -42,6 +42,7 @@ jobs:
 
     steps:
     - name: Add repositories
+      timeout-minutes: 15
       run: |
         apt-get update
         apt-get install -y wget lsb-release gnupg apt-transport-https sudo postgresql-common jq
@@ -57,6 +58,7 @@ jobs:
 
 
     - name: Install timescaledb
+      timeout-minutes: 15
       run: |
         apt-get update
         apt-get install -y --no-install-recommends \
@@ -108,6 +110,7 @@ jobs:
         fi
 
     - name: Install toolkit
+      timeout-minutes: 15
       run: |
         apt-get install -y --no-install-recommends \
           timescaledb-toolkit-postgresql-${{ matrix.pg }}

.github/workflows/coccinelle.yaml

@@ -14,7 +14,8 @@ jobs:
     runs-on: ubuntu-22.04
 
     steps:
-    - name: Install Dependencies
+    - name: Install Linux Dependencies
+      timeout-minutes: 15
       run: |
         sudo apt-get update
         sudo apt-get -y install coccinelle

.github/workflows/code_style.yaml

@@ -77,16 +77,17 @@ jobs:
     env:
       LLVM_VER: 17
     steps:
-    - name: Install dependencies
+    - name: Install Linux Dependencies
+      timeout-minutes: 15
       run: |
-          gpg --batch --keyserver hkp://keyserver.ubuntu.com --recv-keys 15CF4D18AF4F7421
-          gpg --batch --export --export-options export-minimal --armor 15CF4D18AF4F7421 | sudo tee /etc/apt/trusted.gpg.d/apt.llvm.org.asc > /dev/null
+        gpg --batch --keyserver hkp://keyserver.ubuntu.com --recv-keys 15CF4D18AF4F7421
+        gpg --batch --export --export-options export-minimal --armor 15CF4D18AF4F7421 | sudo tee /etc/apt/trusted.gpg.d/apt.llvm.org.asc > /dev/null
 
-          . /etc/os-release
-          echo "deb https://apt.llvm.org/${VERSION_CODENAME}/ llvm-toolchain-${VERSION_CODENAME}-${LLVM_VER} main" | sudo tee /etc/apt/sources.list.d/llvm.list >/dev/null
-          sudo apt-get update
+        . /etc/os-release
+        echo "deb https://apt.llvm.org/${VERSION_CODENAME}/ llvm-toolchain-${VERSION_CODENAME}-${LLVM_VER} main" | sudo tee /etc/apt/sources.list.d/llvm.list >/dev/null
+        sudo apt-get update
 
-          sudo apt-get install clang-format-${LLVM_VER}
+        sudo apt-get install clang-format-${LLVM_VER}
     - name: Checkout source
       uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
     - name: Check trailing whitespace

.github/workflows/coverity.yaml

@@ -22,7 +22,8 @@ jobs:
         pg: [16, 17, 18]
         os: [ubuntu-22.04]
     steps:
-    - name: Install Dependencies
+    - name: Install Linux Dependencies
+      timeout-minutes: 15
       run: |
         sudo apt-get update
         sudo apt-get install gnupg systemd-coredump gdb postgresql-common

.github/workflows/issue-handling.yaml

@@ -100,7 +100,8 @@ jobs:
     runs-on: timescaledb-runner-arm64
     if: github.event_name == 'issue_comment' && !github.event.issue.pull_request
     steps:
-      - name: Install dependencies
+      - name: Install Linux Dependencies
+        timeout-minutes: 15
         run: |
           sudo apt-get update
           sudo apt-get install jq

.github/workflows/libfuzzer.yaml

@@ -22,6 +22,7 @@ jobs:
 
     steps:
     - name: Install Linux Dependencies
+      timeout-minutes: 15
       run: |
         # Don't add ddebs here because the ddebs mirror is always 503 Service Unavailable.
         # If needed, install them before opening the core dump.
@@ -144,9 +145,10 @@ jobs:
 
     steps:
     - name: Install Linux dependencies
+      timeout-minutes: 15
       run: |
-        sudo apt update
-        sudo apt install 7zip systemd-coredump gdb
+        sudo apt-get update
+        sudo apt-get install 7zip systemd-coredump gdb
 
     - name: Checkout TimescaleDB
       uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

.github/workflows/linux-32bit-build-and-test.yaml

@@ -101,11 +101,13 @@ jobs:
 
     # /__e/node16/bin/node (used by actions/checkout@v4) needs 64-bit libraries
     - name: Install 64-bit libraries for GitHub actions
+      timeout-minutes: 15
       run: |
         apt-get update
         apt-get install -y lib64atomic1 lib64gcc-s1 lib64stdc++6 libc6-amd64 jq
 
     - name: Install build dependencies
+      timeout-minutes: 15
       run: |
         PG_MAJOR=$(echo "${{ matrix.pg }}" | sed -e 's![.].*!!')
         echo '/tmp/core.%h.%e.%t' > /proc/sys/kernel/core_pattern

.github/workflows/linux-build-and-test.yaml

@@ -78,20 +78,27 @@ jobs:
     steps:
     - name: Install Linux Dependencies
       if: runner.os == 'Linux'
+      timeout-minutes: 15
       run: |
         # Don't add ddebs here because the ddebs mirror is always 503 Service Unavailable.
         # If needed, install them before opening the core dump.
         sudo apt-get update
         sudo apt-get install flex bison lcov systemd-coredump gdb libipc-run-perl \
           libtest-most-perl pkgconf icu-devtools faketime jq ${{ matrix.extra_packages }}
 
-    - name: Install macOS Dependencies
+    - name: Check macOS Build Dependencies
       if: runner.os == 'macOS'
+      run: |
+        # OpenSSL is supposed to be preinstalled, so just check its path here
+        brew --prefix openssl@3
+
+    - name: Install macOS Test Dependencies
+      if: runner.os == 'macOS' && matrix.installcheck
+      timeout-minutes: 15
       run: |
         # Disable the automatic dependency upgrade executed by `brew install`
         # https://docs.brew.sh/Manpage#install-options-formulacask-
         HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK=1 brew install gawk
-        brew --prefix openssl@3
         # Install perl modules after last Homebew call, since Homebrew can change the perl version
         sudo perl -MCPAN -e "CPAN::Shell->notest('install', 'IPC::Run')"
         sudo perl -MCPAN -e "CPAN::Shell->notest('install', 'Test::Most')"
@@ -183,6 +190,7 @@ jobs:
         ./bootstrap -DCMAKE_BUILD_TYPE="${{ matrix.build_type }}" \
           -DPG_SOURCE_DIR=$HOME/$PG_SRC_DIR -DPG_PATH=$HOME/$PG_INSTALL_DIR \
           ${{ matrix.tsdb_build_args }} -DCODECOVERAGE=${{ matrix.coverage }} \
+          -DREQUIRE_ALL_TESTS=${{ matrix.installcheck && 'ON' || 'OFF' }} \
           -DTEST_PG_LOG_DIRECTORY="$(readlink -f .)"
         make -j $(getconf _NPROCESSORS_ONLN) -C build
         make -C build install