Fix NULL derefencing in columnar_result_finalize (#9818)

natalya-aksman · web-flow · commit f54a72299825 · 2026-05-15T10:37:12.000-04:00
Fix Coverity report issue: 

        &gt;&gt;&gt;     CID 503639:           (FORWARD_NULL)
&gt;&gt;&gt; Passing "&amp;columnar_result" to "columnar_result_finalize", which
dereferences null "columnar_result.offset_buffer".
594 return columnar_result_finalize(&amp;columnar_result, batch_state);
diff --git a/tsl/src/nodes/vector_agg/exec.c b/tsl/src/nodes/vector_agg/exec.c
@@ -237,6 +237,8 @@ columnar_result_finalize(ColumnarResult *columnar_result, DecompressBatchState c
 	}
 	else if (columnar_result->type == DT_ArrowText)
 	{
+		/* offset_buffer should be allocated for ArrowText type */
+		Assert(columnar_result->offset_buffer != NULL);
 		columnar_result->offset_buffer[nrows] = columnar_result->current_offset;
 
 		arrow_result = MemoryContextAllocZero(batch_state->per_batch_context,

Original file line number	Diff line number	Diff line change
`@@ -237,6 +237,8 @@ columnar_result_finalize(ColumnarResult *columnar_result, DecompressBatchState c`
`237`	`237`	`}`
`238`	`238`	`else if (columnar_result->type == DT_ArrowText)`
`239`	`239`	`{`
	`240`	`+ /* offset_buffer should be allocated for ArrowText type */`
	`241`	`+ Assert(columnar_result->offset_buffer != NULL);`
`240`	`242`	`columnar_result->offset_buffer[nrows] = columnar_result->current_offset;`
`241`	`243`
`242`	`244`	`arrow_result = MemoryContextAllocZero(batch_state->per_batch_context,`