Adopt PG19 CheckValidResultRel signature - #10277
Merged
Merged
Conversation
|
@kpan2034, @pnthao: please review this pull request.
|
svenklemm
force-pushed
the
sven/pg19_beta2
branch
from
July 16, 2026 16:45
ca09063 to
86c0a8c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
dbeck
approved these changes
Jul 17, 2026
akuzm
approved these changes
Jul 17, 2026
svenklemm
force-pushed
the
sven/pg19_beta2
branch
from
July 17, 2026 10:51
7c6aa30 to
d6e2f90
Compare
PostgreSQL 19 added a ModifyTable argument to CheckValidResultRel. Update the CheckValidResultRelCompat macro to take the new argument and shim it away for older versions. Upstream changes: Reject child partition FDWs in FOR PORTION OF. postgres/postgres@a40fdf658862
columnar_scan_cost tet was changed to being pg version specific due to cost differences on PG19. Adjust the IGNORES list for 32bit test to account for that.
Commit 2be68a7 adjusted compression_update_delete but forgot to adjust the PG19 output.
svenklemm
force-pushed
the
sven/pg19_beta2
branch
from
July 17, 2026 11:12
d6e2f90 to
6d7eda8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL 19 added a ModifyTable argument to CheckValidResultRel.
Update the CheckValidResultRelCompat macro to take the new argument
and shim it away for older versions.
Upstream changes:
Reject child partition FDWs in FOR PORTION OF.
postgres/postgres@a40fdf658862
Disable-check: force-changelog-file
Disable-check: commit-count