In "tests fail on old code" workflow, the old code must be the merge base - #10389
Open
akuzm wants to merge 1 commit into
Open
In "tests fail on old code" workflow, the old code must be the merge base#10389akuzm wants to merge 1 commit into
akuzm wants to merge 1 commit into
Conversation
Otherwise we can run into weird inconsistencies with the partial checkout, when the base reference of the PR is sufficiently older than main. We already changed the diff to compare against merge base, but forgot to change the checkout itself.
|
@kpan2034, @dbeck: please review this pull request.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise we can run into weird inconsistencies with the partial checkout, when the base reference of the PR is sufficiently older than main. We already changed the diff to compare against merge base, but forgot to change the checkout itself.
Example failure: https://github.com/timescale/timescaledb/actions/runs/30245168988/job/91209108893