Fix wrong results with IS NULL and minmax pushdown - #10398
Open
svenklemm wants to merge 1 commit into
Open
Conversation
A qual like (v > 0) IS NULL wrapped an operator whose minmax pushdown is a lossy, false-positive-only approximation. Wrapping that lossy result in a NullTest could turn a false positive into a false negative and skip a batch that actually holds matching rows, so the query returned wrong results. Only push down NullTest and the other transforming nodes when their child is pushed down exactly, never when the child still needs a recheck. Fixes #9921
|
@Poroma-Banerjee, @melihmutlu: please review this pull request.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
akuzm
approved these changes
Aug 4, 2026
antekresic
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A qual like (v > 0) IS NULL wrapped an operator whose minmax pushdown is
a lossy, false-positive-only approximation. Wrapping that lossy result in
a NullTest could turn a false positive into a false negative and skip a
batch that actually holds matching rows, so the query returned wrong
results.
Only push down NullTest and the other transforming nodes when their child
is pushed down exactly, never when the child still needs a recheck.
Fixes #9921