From a2a997ddb554ec0a028e736efd540a7c2ab1a070 Mon Sep 17 00:00:00 2001 From: Alexander Kuzmenkov <36882414+akuzm@users.noreply.github.com> Date: Mon, 1 Jun 2026 18:42:33 +0200 Subject: [PATCH 1/4] Use "opinionated reviews" GraphQL API to account for dismissed reviews The normal "reviews" include the full review history like discarded old reviews, which should not contribute to the approval count. --- .github/workflows/pr-approvals.yaml | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/.github/workflows/pr-approvals.yaml b/.github/workflows/pr-approvals.yaml index 14400ef4d7b..a63657cb487 100644 --- a/.github/workflows/pr-approvals.yaml +++ b/.github/workflows/pr-approvals.yaml @@ -39,13 +39,22 @@ jobs: # Get the number of approvals in this pull request echo "Reviews: " gh pr view $PR_NUMBER --json reviews - approvals=$( - gh pr view $PR_NUMBER --json reviews --jq ' - [ - .reviews.[] - | select(.authorAssociation == "MEMBER" and .state == "APPROVED") - ] | length - ' + approvals=$(gh api graphql -F owner=${{ github.repository_owner }} \ + -F name=${{ github.event.repository.name }} -F number=$PR_NUMBER \ + -f query=' + query($owner:String!, $name:String!, $number:Int!) { + repository(owner:$owner, name:$name) { + pullRequest(number:$number) { + latestOpinionatedReviews(first: 100) { + nodes { state authorAssociation } + } + } + } + } + ' --jq '[ + .data.repository.pullRequest.latestOpinionatedReviews.nodes[] + | select(.authorAssociation == "MEMBER" and .state == "APPROVED") + ] | length' ) echo "approvals: $approvals, files: $files" if [[ $approvals -lt 2 && $files -gt 0 ]] ; then From 05e3c9b9f5d038ac48e877c76228894abcba3ebe Mon Sep 17 00:00:00 2001 From: Alexander Kuzmenkov <36882414+akuzm@users.noreply.github.com> Date: Tue, 2 Jun 2026 12:16:31 +0200 Subject: [PATCH 2/4] test --- timescaledb.control.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/timescaledb.control.in b/timescaledb.control.in index 0615b69f823..8031fead9d6 100644 --- a/timescaledb.control.in +++ b/timescaledb.control.in @@ -6,3 +6,5 @@ module_pathname = '$libdir/timescaledb-@PROJECT_VERSION_MOD@' #(though this extension is relocatable during installation). relocatable = false trusted = true + +#FIXME From bf14b49fa5b565ceafbd569daf151cf762af4da2 Mon Sep 17 00:00:00 2001 From: Alexander Kuzmenkov <36882414+akuzm@users.noreply.github.com> Date: Tue, 2 Jun 2026 12:17:06 +0200 Subject: [PATCH 3/4] test 2 --- src/CMakeLists.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 29e03ff8287..1848c1f6088 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -1,3 +1,4 @@ +#FIXME set(SOURCES uuid.c agg_bookend.c From 9b80e87354d391cf7ed5ab4c2aca20c67856bf7f Mon Sep 17 00:00:00 2001 From: Alexander Kuzmenkov <36882414+akuzm@users.noreply.github.com> Date: Tue, 2 Jun 2026 12:36:04 +0200 Subject: [PATCH 4/4] remove --- src/CMakeLists.txt | 1 - timescaledb.control.in | 2 -- 2 files changed, 3 deletions(-) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 1848c1f6088..29e03ff8287 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -1,4 +1,3 @@ -#FIXME set(SOURCES uuid.c agg_bookend.c diff --git a/timescaledb.control.in b/timescaledb.control.in index 8031fead9d6..0615b69f823 100644 --- a/timescaledb.control.in +++ b/timescaledb.control.in @@ -6,5 +6,3 @@ module_pathname = '$libdir/timescaledb-@PROJECT_VERSION_MOD@' #(though this extension is relocatable during installation). relocatable = false trusted = true - -#FIXME