fix: refine safe mode restrictions for feature cvars

timfox · timfox · commit ac3effed81d5 · 2026-01-19T00:58:41.000-08:00
Updated the safe mode restrictions to only apply if the cvar was successfully created. This change ensures that safe mode behavior is correctly enforced without affecting the registration of features that may not have valid cvars. This improves the robustness of feature management in the renderer.
diff --git a/src/renderers/renderer_features.c b/src/renderers/renderer_features.c
@@ -94,8 +94,8 @@ void R_RegisterFeatureCvars(const renderer_feature_t *features, int count) {
             Cvar_SetDescription(cvar, feature->description);
         }
 
-        // Apply safe mode restrictions
-        if (g_safe_mode.enabled) {
+        // Apply safe mode restrictions (only if cvar was successfully created)
+        if (cvar && g_safe_mode.enabled) {
             const char *safe_value = NULL;
 
             if (feature->category == FEATURE_EXPERIMENTAL && g_safe_mode.disable_experimental) {

Original file line number	Diff line number	Diff line change
`@@ -94,8 +94,8 @@ void R_RegisterFeatureCvars(const renderer_feature_t *features, int count) {`
`94`	`94`	`Cvar_SetDescription(cvar, feature->description);`
`95`	`95`	`}`
`96`	`96`
`97`		`- // Apply safe mode restrictions`
`98`		`- if (g_safe_mode.enabled) {`
	`97`	`+ // Apply safe mode restrictions (only if cvar was successfully created)`
	`98`	`+ if (cvar && g_safe_mode.enabled) {`
`99`	`99`	`const char *safe_value = NULL;`
`100`	`100`
`101`	`101`	`if (feature->category == FEATURE_EXPERIMENTAL && g_safe_mode.disable_experimental) {`