Change ast_node_type_to_string to use hb_string

Author: timkaechele

templates/ext/herb/nodes.c.erb

@@ -22,7 +22,8 @@ static VALUE rb_<%= node.human %>_from_c_struct(<%= node.struct_type %>* <%= nod
   VALUE Node = rb_define_class_under(AST, "Node", rb_cObject);
   VALUE <%= node.name %> = rb_define_class_under(AST, "<%= node.name %>", Node);
 
-  VALUE type = rb_utf8_str_new_cstr(ast_node_type_to_string(node));
+  hb_string_T node_type = ast_node_type_to_string(node);
+  VALUE type = rb_utf8_str_new(node_type.data, node_type.length);
   VALUE location = rb_location_from_c_struct(node->location);
   VALUE errors = rb_errors_array_from_c_array(node->errors);
 

templates/javascript/packages/node/extension/nodes.cpp.erb

@@ -25,7 +25,7 @@ napi_value <%= node.human %>NodeFromCStruct(napi_env env, <%= node.struct_type %
   napi_value result;
   napi_create_object(env, &result);
 
-  napi_value type = CreateString(env, ast_node_type_to_string(&<%= node.human %>->base));
+  napi_value type = CreateStringFromHbString(env, ast_node_type_to_string(&<%= node.human %>->base));
   napi_set_named_property(env, result, "type", type);
 
   napi_value location = CreateLocation(env, <%= node.human %>->base.location);

templates/src/ast_nodes.c.erb

@@ -49,14 +49,14 @@
 }
 <%- end -%>
 
-const char* ast_node_type_to_string(AST_NODE_T* node) {
+hb_string_T ast_node_type_to_string(AST_NODE_T* node) {
   switch (node->type) {
     <%- nodes.each do |node| -%>
-    case <%= node.type %>: return "<%= node.type %>";
+    case <%= node.type %>: return hb_string("<%= node.type %>");
     <%- end -%>
   }
 
-  return "Unknown ast_node_type_T";
+  return hb_string("Unknown ast_node_type_T");
 }
 
 hb_string_T ast_node_human_type(AST_NODE_T* node) {

templates/src/include/ast_nodes.h.erb

@@ -41,7 +41,7 @@ typedef struct <%= node.struct_name %> {
 <%= node.struct_type %>* ast_<%= node.human %>_init(<%= arguments.join(", ") %>);
 <%- end -%>
 
-const char* ast_node_type_to_string(AST_NODE_T* node);
+hb_string_T ast_node_type_to_string(AST_NODE_T* node);
 hb_string_T ast_node_human_type(AST_NODE_T* node);
 
 #endif

templates/wasm/nodes.cpp.erb

@@ -21,7 +21,7 @@ val <%= node.name %>FromCStruct(<%= node.struct_type %>* <%= node.human %>) {
   if (!<%= node.human %>) return val::null();
 
   val result = val::object();
-  result.set("type", CreateString(ast_node_type_to_string(&<%= node.human %>->base)));
+  result.set("type", CreateStringFromHbString(ast_node_type_to_string(&<%= node.human %>->base)));
   result.set("location", CreateLocation(<%= node.human %>->base.location));
   result.set("errors", ErrorsArrayFromCArray(<%= node.human %>->base.errors));