Deprecated warning when clearing brand image

[dalers]

Deprecated warning when editing a brand to delete the brand image (using PHP 8.2).

What is your opinion on creating issues for deprecated warnings? It seems this will not become a fatal error until PHP 9.0 ("likely late 2027 or 2028"), but they could make a nice todo list for when we want to support PHP 9.0 if they were given a label like e.g. "PHP 9.0".

Warning: Undefined variable $ImageFile in C:\xampp\htdocs\weberp\Manufacturers.php on line 87

Deprecated: is_file(): Passing null to parameter #1 ($filename) of type string is deprecated in C:\xampp\htdocs\weberp\Manufacturers.php on line 87

add brand with image

edit brand and attempt to clear image

result

[pakricard]

Hi @dalers : Good idea to label them as PHP9 or similar.

I keep fixing these issues when I encounter them. The best way is to develop with error_reporting(-1);

BTW, I found that VCS copilot fixes these issues very rapidly. Just open the file, and prompt the error message, and in most cases, VCS finds the solution without much neurons' usage from my side.

R

[timschofield]

I pretty much agree with Ricard's points. I develop using error_reporting set to -1 and try to fix them as I find them.

Tim