Skip to content
This repository was archived by the owner on Dec 28, 2022. It is now read-only.

Commit edaea84

Browse files
committed
Fixed a crash when adding to queue from FolderFragment
1 parent a451511 commit edaea84

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed

app/src/main/java/com/simplecity/amp_library/ui/screens/folders/FolderFragment.java

+4-3
Original file line numberDiff line numberDiff line change
@@ -660,13 +660,14 @@ public boolean onMenuItemClick(MenuItem menuItem) {
660660
FolderMenuUtils.Callbacks callbacks = new FolderMenuUtils.Callbacks() {
661661

662662
@Override
663-
public void onQueueItemsInserted(int numSongs) {
664-
// Todo: Implement
663+
public void onSongsAddedToQueue(int numSongs) {
664+
Toast.makeText(getContext(), getContext().getResources().getQuantityString(R.plurals.NNNtrackstoqueue, numSongs, numSongs), Toast.LENGTH_SHORT).show();
665665
}
666666

667667
@Override
668668
public void onPlaybackFailed() {
669-
// Todo: Implement
669+
// Todo: Improve error message
670+
Toast.makeText(getContext(), R.string.emptyplaylist, Toast.LENGTH_SHORT).show();
670671
}
671672

672673
@Override

app/src/main/java/com/simplecity/amp_library/utils/menu/folder/FolderMenuUtils.kt

+10-5
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@ object FolderMenuUtils {
4141

4242
fun showToast(@StringRes messageResId: Int)
4343

44+
fun onSongsAddedToQueue(numSongs: Int)
45+
4446
fun onPlaybackFailed()
4547

4648
fun shareSong(song: Song)
@@ -51,8 +53,6 @@ object FolderMenuUtils {
5153

5254
fun onPlaylistItemsInserted()
5355

54-
fun onQueueItemsInserted(numSongs: Int)
55-
5656
fun showTagEditor(song: Song)
5757

5858
fun onFileNameChanged(folderView: FolderView)
@@ -236,7 +236,7 @@ object FolderMenuUtils {
236236
return@OnMenuItemClickListener true
237237
}
238238
R.id.addToQueue -> {
239-
MenuUtils.addToQueue(mediaManager, getSongsForFolderObject(songsRepository, folderObject)) { callbacks.onQueueItemsInserted(it) }
239+
MenuUtils.addToQueue(mediaManager, getSongsForFolderObject(songsRepository, folderObject)) { callbacks.onSongsAddedToQueue(it) }
240240
return@OnMenuItemClickListener true
241241
}
242242
R.id.scan -> {
@@ -279,7 +279,12 @@ object FolderMenuUtils {
279279

280280
when (menuItem.itemId) {
281281
R.id.playNext -> {
282-
getSongForFile(songsRepository, fileObject).subscribe({ song -> mediaManager.playNext(listOf(song)) { callbacks.showToast(it) } }, errorHandler)
282+
getSongForFile(songsRepository, fileObject)
283+
.observeOn(AndroidSchedulers.mainThread())
284+
.subscribe(
285+
{ song -> mediaManager.playNext(listOf(song)) { callbacks.onSongsAddedToQueue(it) } },
286+
errorHandler
287+
)
283288
return@OnMenuItemClickListener true
284289
}
285290
Defs.NEW_PLAYLIST -> {
@@ -302,7 +307,7 @@ object FolderMenuUtils {
302307
return@OnMenuItemClickListener true
303308
}
304309
R.id.addToQueue -> {
305-
getSongForFile(songsRepository, fileObject).subscribe({ song -> MenuUtils.addToQueue(mediaManager, listOf(song), { callbacks.onQueueItemsInserted(it) }) }, errorHandler)
310+
getSongForFile(songsRepository, fileObject).subscribe({ song -> MenuUtils.addToQueue(mediaManager, listOf(song), { callbacks.onSongsAddedToQueue(it) }) }, errorHandler)
306311
return@OnMenuItemClickListener true
307312
}
308313
R.id.scan -> {

0 commit comments

Comments
 (0)