Skip to content
This repository was archived by the owner on Apr 17, 2024. It is now read-only.

Commit b8f7f7c

Browse files
tholenstcopybara-github
authored andcommitted
Remove tests which create undefined behavior.
PiperOrigin-RevId: 624909243
1 parent 735315f commit b8f7f7c

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

cc/util/enums_test.cc

-12
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,6 @@ TEST_F(EnumsTest, testEllipticCurveType) {
4646
Enums::SubtleToProto(subtle::EllipticCurveType::CURVE25519));
4747
EXPECT_EQ(pb::EllipticCurveType::UNKNOWN_CURVE,
4848
Enums::SubtleToProto(subtle::EllipticCurveType::UNKNOWN_CURVE));
49-
EXPECT_EQ(pb::EllipticCurveType::UNKNOWN_CURVE,
50-
Enums::SubtleToProto((subtle::EllipticCurveType)42));
5149

5250
EXPECT_EQ(subtle::EllipticCurveType::NIST_P256,
5351
Enums::ProtoToSubtle(pb::EllipticCurveType::NIST_P256));
@@ -59,8 +57,6 @@ TEST_F(EnumsTest, testEllipticCurveType) {
5957
Enums::ProtoToSubtle(pb::EllipticCurveType::CURVE25519));
6058
EXPECT_EQ(subtle::EllipticCurveType::UNKNOWN_CURVE,
6159
Enums::ProtoToSubtle(pb::EllipticCurveType::UNKNOWN_CURVE));
62-
EXPECT_EQ(subtle::EllipticCurveType::UNKNOWN_CURVE,
63-
Enums::ProtoToSubtle((pb::EllipticCurveType)42));
6460

6561
// Check that enum conversion covers the entire range of the proto-enum.
6662
int count = 0;
@@ -87,8 +83,6 @@ TEST_F(EnumsTest, testHashType) {
8783
Enums::SubtleToProto(subtle::HashType::SHA512));
8884
EXPECT_EQ(pb::HashType::UNKNOWN_HASH,
8985
Enums::SubtleToProto(subtle::HashType::UNKNOWN_HASH));
90-
EXPECT_EQ(pb::HashType::UNKNOWN_HASH,
91-
Enums::SubtleToProto((subtle::HashType)42));
9286

9387
EXPECT_EQ(subtle::HashType::SHA1, Enums::ProtoToSubtle(pb::HashType::SHA1));
9488
EXPECT_EQ(subtle::HashType::SHA224,
@@ -101,8 +95,6 @@ TEST_F(EnumsTest, testHashType) {
10195
Enums::ProtoToSubtle(pb::HashType::SHA512));
10296
EXPECT_EQ(subtle::HashType::UNKNOWN_HASH,
10397
Enums::ProtoToSubtle(pb::HashType::UNKNOWN_HASH));
104-
EXPECT_EQ(subtle::HashType::UNKNOWN_HASH,
105-
Enums::ProtoToSubtle((pb::HashType)42));
10698

10799
// Check that enum conversion covers the entire range of the proto-enum.
108100
int count = 0;
@@ -147,8 +139,6 @@ TEST_F(EnumsTest, testEcPointFormat) {
147139
Enums::ProtoToSubtle(pb::EcPointFormat::COMPRESSED));
148140
EXPECT_EQ(subtle::EcPointFormat::UNKNOWN_FORMAT,
149141
Enums::ProtoToSubtle(pb::EcPointFormat::UNKNOWN_FORMAT));
150-
EXPECT_EQ(subtle::EcPointFormat::UNKNOWN_FORMAT,
151-
Enums::ProtoToSubtle((pb::EcPointFormat)42));
152142

153143
// Check that enum conversion covers the entire range of the proto-enum.
154144
int count = 0;
@@ -202,8 +192,6 @@ TEST_F(EnumsTest, testKeyStatusName) {
202192
EXPECT_EQ(
203193
"UNKNOWN_STATUS",
204194
std::string(Enums::KeyStatusName(pb::KeyStatusType::UNKNOWN_STATUS)));
205-
EXPECT_EQ("UNKNOWN_STATUS",
206-
std::string(Enums::KeyStatusName((pb::KeyStatusType)42)));
207195

208196
EXPECT_EQ(pb::KeyStatusType::ENABLED, Enums::KeyStatus("ENABLED"));
209197
EXPECT_EQ(pb::KeyStatusType::DISABLED, Enums::KeyStatus("DISABLED"));

0 commit comments

Comments
 (0)