Commit f2b3702
Fix regex for git short hashes (#1872)
Follow up of #1871.
Git short hashes can be longer than 7 characters, see the [“Short SHA-1”
section of the git
docs](https://git-scm.com/book/en/v2/Git-Tools-Revision-Selection).
That’s relevant in our Pro repo, as you can [see in our latest
build](https://app.circleci.com/pipelines/github/tiny-pilot/tinypilot-pro/4799/workflows/4ed6c793-a8f1-458e-b29c-434005e5ae0f/jobs/50173),
where the output of `git describe --tags --long` yields
`2.7.0-rc.4-5-g0bfe1e1f`, i.e. with 8 characters following the `-g`.
Therefore, the regex replacement didn’t match.
Contrary to [my assumption about config
protection](tiny-pilot/tinypilot-pro#1475 (comment))
([which wasn’t
correct](tiny-pilot/tinypilot-pro#1475 (comment))),
this seems to be the actual reason why the change didn’t have any effect
in the PR build.
<a data-ca-tag
href="https://codeapprove.com/pr/tiny-pilot/tinypilot/1872"><img
src="https://codeapprove.com/external/github-tag-allbg.png" alt="Review
on CodeApprove" /></a>
Co-authored-by: Jan Heuermann <jan@jotaen.net>1 parent 41e4dea commit f2b3702
1 file changed
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| 30 | + | |
| 31 | + | |
30 | 32 | | |
31 | | - | |
| 33 | + | |
32 | 34 | | |
33 | 35 | | |
34 | 36 | | |
| |||
0 commit comments