Skip to content

Commit a004f53

Browse files
committed
GNUmakefile: enable recovered wasm package tests
Move the standard library packages that were blocked by missing panic recovery into the portable test set. Keep image excluded from bare wasm because its tests require filesystem fixtures. Also enable crypto/ecdsa in the fast WASI suite now that Goexit runs deferred calls.
1 parent e9cde59 commit a004f53

1 file changed

Lines changed: 10 additions & 23 deletions

File tree

GNUmakefile

Lines changed: 10 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -337,8 +337,10 @@ TEST_PACKAGES_FAST = \
337337
container/heap \
338338
container/list \
339339
container/ring \
340+
crypto/des \
340341
crypto/ecdsa \
341342
crypto/elliptic \
343+
crypto/hmac \
342344
crypto/md5 \
343345
crypto/sha1 \
344346
crypto/sha256 \
@@ -365,6 +367,7 @@ TEST_PACKAGES_FAST = \
365367
hash/crc64 \
366368
hash/fnv \
367369
html \
370+
image \
368371
internal/itoa \
369372
internal/profile \
370373
math \
@@ -375,10 +378,14 @@ TEST_PACKAGES_FAST = \
375378
os \
376379
path \
377380
reflect \
381+
regexp/syntax \
382+
strconv \
378383
sync \
379384
testing \
380385
testing/iotest \
381386
text/scanner \
387+
text/tabwriter \
388+
text/template/parse \
382389
unicode \
383390
unicode/utf16 \
384391
unicode/utf8 \
@@ -389,21 +396,14 @@ TEST_PACKAGES_FAST = \
389396
# bytes requires mmap
390397
# compress/flate appears to hang on wasi
391398
# crypto/aes needs reflect.Type.Method(), not yet implemented
392-
# crypto/des fails on wasi, needs panic()/recover()
393-
# crypto/hmac fails on wasi, it exits with a "slice out of range" panic
394399
# debug/plan9obj requires os.ReadAt, which is not yet supported on windows
395400
# encoding/xml takes a minute on linux and gives a stack overflow on wasi
396-
# image fails on wasi, needs panic()/recover()
397401
# io/ioutil requires os.ReadDir, which is not yet supported on windows or wasi
398-
# mime: fails on wasi, needs panic()/recover()
402+
# mime fails on wasi: bufio.Scanner reports an impossible read count
399403
# mime/multipart: needs wasip1 syscall.FDFLAG_NONBLOCK
400404
# mime/quotedprintable requires syscall.Faccessat
401405
# net/mail: needs wasip1 syscall.FDFLAG_NONBLOCK
402406
# net/ntextproto: needs wasip1 syscall.FDFLAG_NONBLOCK
403-
# regexp/syntax: fails on wasip1, needs panic()/recover()
404-
# strconv: fails on wasi, needs panic()/recover()
405-
# text/tabwriter: fails on wasi, needs panic()/recover()
406-
# text/template/parse: fails on wasi, needs panic()/recover()
407407
# testing/fstest requires os.ReadDir, which is not yet supported on windows or wasi
408408

409409
# Additional standard library packages that pass tests on individual platforms
@@ -412,13 +412,10 @@ TEST_PACKAGES_LINUX := \
412412
compress/flate \
413413
context \
414414
crypto/aes \
415-
crypto/des \
416415
crypto/ecdh \
417-
crypto/hmac \
418416
debug/dwarf \
419417
debug/plan9obj \
420418
encoding/xml \
421-
image \
422419
io/ioutil \
423420
mime \
424421
mime/multipart \
@@ -427,25 +424,15 @@ TEST_PACKAGES_LINUX := \
427424
net/mail \
428425
net/textproto \
429426
os/user \
430-
regexp/syntax \
431-
strconv \
432427
testing/fstest \
433-
text/tabwriter \
434-
text/template/parse
428+
$(nil)
435429

436430
TEST_PACKAGES_DARWIN := $(TEST_PACKAGES_LINUX)
437431

438432
# os/user requires t.Skip() support
439433
TEST_PACKAGES_WINDOWS := \
440434
compress/flate \
441-
crypto/des \
442-
crypto/hmac \
443-
image \
444435
mime \
445-
regexp/syntax \
446-
strconv \
447-
text/tabwriter \
448-
text/template/parse \
449436
$(nil)
450437

451438

@@ -461,6 +448,7 @@ TEST_PACKAGES_NONWASM = \
461448
embed/internal/embedtest \
462449
expvar \
463450
go/format \
451+
image \
464452
os \
465453
testing \
466454
$(nil)
@@ -481,7 +469,6 @@ TEST_PACKAGES_NONBAREMETAL = \
481469

482470
TEST_PACKAGES_FAST_WASI = $(filter-out $(TEST_PACKAGES_NOWASI), $(TEST_PACKAGES_FAST))
483471
TEST_PACKAGES_NOWASI = \
484-
crypto/ecdsa \
485472
$(nil)
486473

487474
# Report platforms on which each standard library package is known to pass tests

0 commit comments

Comments
 (0)