Skip to content

Commit e5f8aee

Browse files
committed
GNUmakefile: enable recovered wasm package tests
Move the standard library packages that were blocked by missing panic recovery into the portable test set. Keep image excluded from bare wasm because its tests require filesystem fixtures. Also enable crypto/ecdsa in the fast WASI suite now that Goexit runs deferred calls.
1 parent e9cde59 commit e5f8aee

1 file changed

Lines changed: 8 additions & 19 deletions

File tree

GNUmakefile

Lines changed: 8 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -337,6 +337,7 @@ TEST_PACKAGES_FAST = \
337337
container/heap \
338338
container/list \
339339
container/ring \
340+
crypto/des \
340341
crypto/ecdsa \
341342
crypto/elliptic \
342343
crypto/md5 \
@@ -365,6 +366,7 @@ TEST_PACKAGES_FAST = \
365366
hash/crc64 \
366367
hash/fnv \
367368
html \
369+
image \
368370
internal/itoa \
369371
internal/profile \
370372
math \
@@ -375,10 +377,14 @@ TEST_PACKAGES_FAST = \
375377
os \
376378
path \
377379
reflect \
380+
regexp/syntax \
381+
strconv \
378382
sync \
379383
testing \
380384
testing/iotest \
381385
text/scanner \
386+
text/tabwriter \
387+
text/template/parse \
382388
unicode \
383389
unicode/utf16 \
384390
unicode/utf8 \
@@ -389,21 +395,15 @@ TEST_PACKAGES_FAST = \
389395
# bytes requires mmap
390396
# compress/flate appears to hang on wasi
391397
# crypto/aes needs reflect.Type.Method(), not yet implemented
392-
# crypto/des fails on wasi, needs panic()/recover()
393398
# crypto/hmac fails on wasi, it exits with a "slice out of range" panic
394399
# debug/plan9obj requires os.ReadAt, which is not yet supported on windows
395400
# encoding/xml takes a minute on linux and gives a stack overflow on wasi
396-
# image fails on wasi, needs panic()/recover()
397401
# io/ioutil requires os.ReadDir, which is not yet supported on windows or wasi
398402
# mime: fails on wasi, needs panic()/recover()
399403
# mime/multipart: needs wasip1 syscall.FDFLAG_NONBLOCK
400404
# mime/quotedprintable requires syscall.Faccessat
401405
# net/mail: needs wasip1 syscall.FDFLAG_NONBLOCK
402406
# net/ntextproto: needs wasip1 syscall.FDFLAG_NONBLOCK
403-
# regexp/syntax: fails on wasip1, needs panic()/recover()
404-
# strconv: fails on wasi, needs panic()/recover()
405-
# text/tabwriter: fails on wasi, needs panic()/recover()
406-
# text/template/parse: fails on wasi, needs panic()/recover()
407407
# testing/fstest requires os.ReadDir, which is not yet supported on windows or wasi
408408

409409
# Additional standard library packages that pass tests on individual platforms
@@ -412,13 +412,11 @@ TEST_PACKAGES_LINUX := \
412412
compress/flate \
413413
context \
414414
crypto/aes \
415-
crypto/des \
416415
crypto/ecdh \
417416
crypto/hmac \
418417
debug/dwarf \
419418
debug/plan9obj \
420419
encoding/xml \
421-
image \
422420
io/ioutil \
423421
mime \
424422
mime/multipart \
@@ -427,25 +425,16 @@ TEST_PACKAGES_LINUX := \
427425
net/mail \
428426
net/textproto \
429427
os/user \
430-
regexp/syntax \
431-
strconv \
432428
testing/fstest \
433-
text/tabwriter \
434-
text/template/parse
429+
$(nil)
435430

436431
TEST_PACKAGES_DARWIN := $(TEST_PACKAGES_LINUX)
437432

438433
# os/user requires t.Skip() support
439434
TEST_PACKAGES_WINDOWS := \
440435
compress/flate \
441-
crypto/des \
442436
crypto/hmac \
443-
image \
444437
mime \
445-
regexp/syntax \
446-
strconv \
447-
text/tabwriter \
448-
text/template/parse \
449438
$(nil)
450439

451440

@@ -461,6 +450,7 @@ TEST_PACKAGES_NONWASM = \
461450
embed/internal/embedtest \
462451
expvar \
463452
go/format \
453+
image \
464454
os \
465455
testing \
466456
$(nil)
@@ -481,7 +471,6 @@ TEST_PACKAGES_NONBAREMETAL = \
481471

482472
TEST_PACKAGES_FAST_WASI = $(filter-out $(TEST_PACKAGES_NOWASI), $(TEST_PACKAGES_FAST))
483473
TEST_PACKAGES_NOWASI = \
484-
crypto/ecdsa \
485474
$(nil)
486475

487476
# Report platforms on which each standard library package is known to pass tests

0 commit comments

Comments
 (0)