Fix lint errors

Author: tiny-ben-tran

eslint.config.mjs

@@ -30,7 +30,8 @@ export default defineConfig([
       '@tinymce/prefer-fun': 'off',
       '@tinymce/prefer-fun': 'off',
       'no-underscore-dangle': 'off',
-      '@typescript-eslint/member-ordering': 'off'
+      '@typescript-eslint/member-ordering': 'off',
+      '@typescript-eslint/parameter-properties': 'off'
     }
   },
   {

stories/form-control/FormControl.component.ts

@@ -1,4 +1,3 @@
-/* eslint-disable no-console */
 import { Component } from '@angular/core';
 import { FormBuilder, FormControl } from '@angular/forms';
 import { apiKey } from 'stories/Settings';
@@ -11,9 +10,9 @@ export class FormControlComponent {
   public apiKey = apiKey;
   public formControl: FormControl<string | null>;
 
-  // eslint-disable-next-line @typescript-eslint/no-parameter-properties
   public constructor(private readonly formBuilder: FormBuilder) {
     this.formControl = this.formBuilder.control<string | null>(null);
+    // eslint-disable-next-line no-console
     this.formControl.valueChanges.subscribe(console.log);
     this.formControl.setValue('<p>Initial value</p>');
     // Console log should be triggered just once

stories/form-with-on-push/form-with-on-push.component.ts

@@ -1,5 +1,4 @@
 /* eslint-disable @typescript-eslint/unbound-method */
-/* eslint-disable @typescript-eslint/no-parameter-properties */
 import {
   Component,
   ChangeDetectionStrategy,

stories/pipes/Safe.pipe.ts

@@ -5,7 +5,6 @@ import { DomSanitizer, SafeHtml } from '@angular/platform-browser';
   name: 'safe'
 })
 export class SafePipe implements PipeTransform {
-  // eslint-disable-next-line @typescript-eslint/no-parameter-properties
   public constructor(protected sanitizer: DomSanitizer) {}
 
   public transform(value: string, type: string): SafeHtml {

tinymce-angular-component/src/main/ts/editor/editor.component.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-parameter-properties */
 import { isPlatformBrowser, CommonModule } from '@angular/common';
 import {
   AfterViewInit,
@@ -114,7 +113,7 @@ export class EditorComponent extends Events implements AfterViewInit, ControlVal
     elementRef: ElementRef,
     ngZone: NgZone,
     private cdRef: ChangeDetectorRef,
-    @Inject(PLATFORM_ID) private platformId: Object,
+    @Inject(PLATFORM_ID) private platformId: object,
     @Optional() @Inject(TINYMCE_SCRIPT_SRC) private tinymceScriptSrc?: string
   ) {
     super();

tinymce-angular-component/src/main/ts/utils/Utils.ts

@@ -82,7 +82,6 @@ const normalizePluginArray = (plugins?: string | string[]): string[] => {
 const mergePlugins = (initPlugins: string | string[], inputPlugins?: string | string[]) =>
   normalizePluginArray(initPlugins).concat(normalizePluginArray(inputPlugins));
 
-// eslint-disable-next-line @typescript-eslint/no-empty-function
 const noop: (...args: any[]) => void = () => { };
 
 const isNullOrUndefined = (value: any): value is null | undefined => value === null || value === undefined;

tinymce-angular-component/src/test/ts/alien/TestHooks.ts

@@ -35,10 +35,10 @@ export interface EditorFixture<T> extends ComponentFixture<T> {
 
 export type CreateEditorFixture<T> = (
   props?: Partial<
-  Omit<
-  EditorComponent,
-    `${'on' | 'ng' | 'register' | 'set' | 'write'}${string}` | 'createElement' | 'initialise' | 'editor'
-  >
+    Omit<
+      EditorComponent,
+      `${'on' | 'ng' | 'register' | 'set' | 'write'}${string}` | 'createElement' | 'initialise' | 'editor'
+    >
   >
 ) => Promise<EditorFixture<T>>;
 

tinymce-angular-component/src/test/ts/browser/NgModelTest.ts

@@ -1,4 +1,4 @@
-/* eslint-disable max-classes-per-file */
+
 import '../alien/InitTestEnvironment';
 
 import { Component } from '@angular/core';

tinymce-angular-component/src/test/ts/browser/PropTest.ts

@@ -59,7 +59,8 @@ describe('PropTest', () => {
           const [ ed ] = await waitForEditorsToLoad(fixture);
           expect(ed.id).to.equal('my-id');
         });
-        expect(containsIDWarning(warnings), 'Should not contain an ID warning').to.be.false;
+
+        expect(containsIDWarning(warnings) === false, 'Should not contain an ID warning');
       });
     });
 
@@ -89,9 +90,9 @@ describe('PropTest', () => {
           const [ ed1, ed2 ] = await waitForEditorsToLoad(fixture);
           expect(ed1.id).to.equal('my-id-0');
           expect(ed1.getContent()).to.equal('<p>text1</p>');
-          expect(ed2).to.be.undefined;
+          expect(ed2).to.equal(undefined);
         });
-        expect(containsIDWarning(warnings), 'Should contain an ID warning').to.be.true;
+        expect(containsIDWarning(warnings) === true, 'Should contain an ID warning');
       });
 
       it('INT-3299: creating more than one editor with different IDs does not log a warning', async () => {
@@ -110,10 +111,10 @@ describe('PropTest', () => {
             expect(ed2.editor?.getContent()).to.equal('<p>text1</p>');
             expect(ed3.id).to.equal('my-id-2');
             expect(ed3.editor?.getContent()).to.equal('<p>text2</p>');
-            expect(ed4?.editor).to.be.undefined;
+            expect(ed4?.editor).to.equal(undefined);
           }, 1000, 10000);
         });
-        expect(containsIDWarning(warnings), 'Should not contain an ID warning').to.be.false;
+        expect(containsIDWarning(warnings), 'Should not contain an ID warning').to.equal(false);
       });
     });
   });