Skip to content

Commit 176ee8e

Browse files
authored
Merge pull request #9 from titicacadev/jayg/20190828/limted-image-carousel
💫캐러셀 스크롤 제한 기능 추가
2 parents 151eb2a + a98b8b6 commit 176ee8e

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

cloudbuild.release.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ steps:
2121
- 'NPM_TOKEN'
2222

2323
substitutions:
24-
_SLACK_NOTIFY_CHANNEL: '#triple-web-dev'
24+
_SLACK_NOTIFY_CHANNEL: '#triple-web-dev-notifications'
2525
_SVC_BASENAME: triple-frontend
2626
_AUTO_TAGGING_ENABLED: 'false'
2727

cloudbuild.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ steps:
4545
]
4646

4747
substitutions:
48-
_SLACK_NOTIFY_CHANNEL: '#triple-web-dev'
48+
_SLACK_NOTIFY_CHANNEL: '#triple-web-dev-notifications'
4949
_SVC_BASENAME: triple-frontend
5050
_AUTO_TAGGING_ENABLED: 'false'
5151

packages/triple-image-carousel/src/index.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ export const ImagePager = ({
3939
onImageClick,
4040
onPageChange,
4141
ImageSource,
42+
lastPageOverlayContent,
4243
}: {
4344
margin?: MarginPadding
4445
borderRadius?: number
@@ -50,6 +51,7 @@ export const ImagePager = ({
5051
onImageClick?: (e?: React.SyntheticEvent, image?: any) => any
5152
onPageChange?: (e?: React.SyntheticEvent) => any
5253
ImageSource?: any
54+
lastPageOverlayContent?: React.ReactNode
5355
}) => (
5456
<Pager
5557
margin={margin}
@@ -78,6 +80,8 @@ export const ImagePager = ({
7880
ImageSource={ImageSource}
7981
borderRadius={0}
8082
onClick={onImageClick && ((e) => onImageClick(e, image))}
83+
overlay={i === images.length - 1 ? { lastPageOverlayContent } : null}
84+
overlayType="dark"
8185
/>
8286
)
8387
})}

0 commit comments

Comments
 (0)