Skip to content
This repository was archived by the owner on Jan 29, 2026. It is now read-only.

[react-contexts] NOL 통합 유저일 경우 로그아웃시 redirect합니다. #3581

Merged
dongoc merged 5 commits intoepic/KLZT-856_nol_userfrom
feat/KLZT-866
Mar 25, 2025
Merged

[react-contexts] NOL 통합 유저일 경우 로그아웃시 redirect합니다. #3581
dongoc merged 5 commits intoepic/KLZT-856_nol_userfrom
feat/KLZT-866

Conversation

@guswl98
Copy link
Copy Markdown
Contributor

@guswl98 guswl98 commented Mar 7, 2025 •
edited by dongoc
Loading

PR 설명

NOL 통합 유저일 경우 로그아웃시 nol 로그아웃 url로 리다이렉트합니다.

  • 302 응답의 경우 브라우저에서 자동으로 redirect하여 프론트에서 query를 붙이지 못하는 이슈가 있습니다.
  • 301 응답의 경우 브라우저에서 response.body를 무시하는 이슈가 있습니다.
  • 따라서 200 응답 + response.body에 redirectUrl이 있는 경우 nolConnected로 판단하여 해당 url로 리다이렉트합니다.

@guswl98 guswl98 self-assigned this Mar 7, 2025
@guswl98 guswl98 changed the base branch from v13 to epic/KLZT-856_nol_user March 7, 2025 05:44
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 41.17647% with 10 lines in your changes missing coverage. Please review.

Project coverage is 10.09%. Comparing base (3acbfca) to head (2c6e0c2).
Report is 16 commits behind head on epic/KLZT-856_nol_user.

Files with missing lines Patch % Lines
...ges/react-contexts/src/session-context/browser.tsx 18.18% 9 Missing ⚠️
...ges/react-contexts/src/session-context/redirect.ts 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@                    Coverage Diff                     @@
##           epic/KLZT-856_nol_user    #3581      +/-   ##
==========================================================
+ Coverage                   10.07%   10.09%   +0.01%     
==========================================================
  Files                         735      736       +1     
  Lines                       28745    28767      +22     
  Branches                     7835     7840       +5     
==========================================================
+ Hits                         2897     2903       +6     
- Misses                      25828    25844      +16     
  Partials                       20       20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@guswl98
Copy link
Copy Markdown
Contributor Author

guswl98 commented Mar 11, 2025

release-canary

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 11, 2025

v13.43.1-pr-3581.2 has been published!

@dongoc
Copy link
Copy Markdown
Contributor

dongoc commented Mar 19, 2025

release-canary

@dongoc dongoc added this to the 13.nol milestone Mar 19, 2025
@dongoc
Copy link
Copy Markdown
Contributor

dongoc commented Mar 19, 2025

release-canary

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 20, 2025

v13.44.1-pr-3581.13 has been published!

@dongoc dongoc changed the title [react-contexts] 로그아웃 요청의 response status가 301, 302일 경우 Location으로 redirect합니다. [react-contexts] NOL 통합 유저일 경우 로그아웃시 redirect합니다. Mar 24, 2025
@dongoc dongoc marked this pull request as ready for review March 25, 2025 04:08
@dongoc dongoc requested a review from a team as a code owner March 25, 2025 04:08
@dongoc dongoc requested review from choisohyun, dia-triple and torres-triple and removed request for a team March 25, 2025 04:08
guswl98
guswl98 commented Mar 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@guswl98 guswl98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dongoc dongoc merged commit 41d7d09 into epic/KLZT-856_nol_user Mar 25, 2025
12 checks passed
@dongoc dongoc deleted the feat/KLZT-866 branch March 25, 2025 04:21
@guswl98 guswl98 mentioned this pull request Apr 15, 2025
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@choisohyun choisohyun Awaiting requested review from choisohyun choisohyun was automatically assigned from titicacadev/frontend

@torres-triple torres-triple Awaiting requested review from torres-triple torres-triple was automatically assigned from titicacadev/frontend

@dia-triple dia-triple Awaiting requested review from dia-triple dia-triple was automatically assigned from titicacadev/frontend

1 more reviewer

@dongoc dongoc dongoc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@guswl98 guswl98

Labels

react-contexts

Projects

None yet

Milestone

13.46.0

Development

Successfully merging this pull request may close these issues.

2 participants

@guswl98 @dongoc