Skip to content
This repository was archived by the owner on Jan 29, 2026. It is now read-only.

[react-contexts] 트리플 deviceId를 추가하는 미들웨어를 작성합니다.#3584

Merged
dongoc merged 5 commits intoepic/KLZT-856_nol_userfrom
KLZT-860_device-id
Mar 11, 2025
Merged

[react-contexts] 트리플 deviceId를 추가하는 미들웨어를 작성합니다.#3584
dongoc merged 5 commits intoepic/KLZT-856_nol_userfrom
KLZT-860_device-id

Conversation

@dongoc
Copy link
Copy Markdown
Contributor

@dongoc dongoc commented Mar 7, 2025

PR 설명

  • 쿠키에 x-triple-web-device-id가 없다면 추가하는 setWebDeviceIdMiddleware를 작성했습니다.
  • 기존 chain 함수가 마지막 middleware만 적용되는 문제가 있었습니다. 모든 middleware가 적용될 수 있도록 수정했습니다.

@dongoc dongoc self-assigned this Mar 7, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 30.76923% with 27 lines in your changes missing coverage. Please review.

Project coverage is 10.07%. Comparing base (12d2b6e) to head (8f7c8ab).
Report is 5 commits behind head on epic/KLZT-856_nol_user.

Files with missing lines Patch % Lines
...eact-contexts/src/middlewares/set-web-device-id.ts 25.00% 15 Missing ⚠️
...-contexts/src/middlewares/old-triple-ios-cookie.ts 25.00% 6 Missing ⚠️
packages/react-contexts/src/middlewares/chain.ts 0.00% 3 Missing ⚠️
.../react-contexts/src/middlewares/refresh-session.ts 60.00% 2 Missing ⚠️
...t-contexts/src/middlewares/utils/get-triple-app.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           epic/KLZT-856_nol_user    #3584      +/-   ##
==========================================================
- Coverage                   10.10%   10.07%   -0.03%     
==========================================================
  Files                         733      735       +2     
  Lines                       28573    28742     +169     
  Branches                     7803     7834      +31     
==========================================================
+ Hits                         2886     2896      +10     
- Misses                      25667    25826     +159     
  Partials                       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dongoc
Copy link
Copy Markdown
Contributor Author

dongoc commented Mar 7, 2025

release-canary

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 7, 2025

v13.44.1-pr-3584.1 has been published!

@dongoc dongoc added this to the 13.45.0 milestone Mar 11, 2025
@dongoc
Copy link
Copy Markdown
Contributor Author

dongoc commented Mar 11, 2025

release-canary

@github-actions
Copy link
Copy Markdown

v13.44.1-pr-3584.3 has been published!

@dongoc dongoc marked this pull request as ready for review March 11, 2025 05:19
@dongoc dongoc requested a review from a team as a code owner March 11, 2025 05:19
@dongoc dongoc requested review from guswl98, inbeom and puffcocos and removed request for a team March 11, 2025 05:19
@dongoc dongoc modified the milestones: 13.45.0, 13.nol Mar 11, 2025
@dongoc dongoc changed the base branch from v13 to epic/KLZT-856_nol_user March 11, 2025 05:31
@dongoc dongoc merged commit 29e0606 into epic/KLZT-856_nol_user Mar 11, 2025
11 checks passed
@dongoc dongoc deleted the KLZT-860_device-id branch March 11, 2025 22:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants