Skip to content
This repository was archived by the owner on Jan 29, 2026. It is now read-only.

tds-widget/chat에서 triple-web 디펜던시를 제거#3586

Merged
dia-triple merged 1 commit intomainfrom
feat/remove-triple-web-dependency
Mar 14, 2025
Merged

tds-widget/chat에서 triple-web 디펜던시를 제거#3586
dia-triple merged 1 commit intomainfrom
feat/remove-triple-web-dependency

Conversation

@dia-triple
Copy link
Copy Markdown
Contributor

@dia-triple dia-triple commented Mar 10, 2025

PR 설명

  • tds-widget/chat에서 triple-web 디펜던시를 제거합니다.

변경 내역

  • onIosTouchMove => onTouchMove로 변경하고, ChatScrollContainer 내부에서 os 확인하는 로직을 제거합니다.
  • 이에따라, 외부에서 os를 확인하여 프롭스를 전달해야 합니다.

체크리스트

스크린샷 & URL

RPReplay_Final1741582800.MP4

@dia-triple dia-triple self-assigned this Mar 10, 2025
@dia-triple dia-triple changed the title feat: tds-widget/chat에서 triple-web 디펜던시를 제거 tds-widget/chat에서 triple-web 디펜던시를 제거 Mar 10, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 14.04%. Comparing base (2d8dc16) to head (32e2ad0).
Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
...tds-widget/src/chat/chat/chat-scroll-container.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3586   +/-   ##
=======================================
  Coverage   14.04%   14.04%           
=======================================
  Files         749      749           
  Lines       10569    10568    -1     
  Branches     3638     3638           
=======================================
  Hits         1484     1484           
+ Misses       8655     8654    -1     
  Partials      430      430           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dia-triple
Copy link
Copy Markdown
Contributor Author

release-canary

@github-actions
Copy link
Copy Markdown

v14.0.12-pr-3586.110 has been published!

@dia-triple dia-triple force-pushed the feat/bubble-info-variant branch from 2ba4fcb to fcb55fa Compare March 10, 2025 04:45
@dia-triple dia-triple added this to the 14.1.0 milestone Mar 10, 2025
@dia-triple dia-triple marked this pull request as ready for review March 10, 2025 05:04
@dia-triple dia-triple requested a review from a team as a code owner March 10, 2025 05:04
@dia-triple dia-triple requested review from dongoc, torres-triple and zzolain and removed request for a team March 10, 2025 05:04
@dia-triple dia-triple marked this pull request as draft March 10, 2025 05:05
@dia-triple dia-triple force-pushed the feat/remove-triple-web-dependency branch from af63f38 to 32e2ad0 Compare March 10, 2025 05:05
@dia-triple dia-triple changed the base branch from feat/bubble-info-variant to main March 10, 2025 05:05
@dia-triple dia-triple marked this pull request as ready for review March 10, 2025 05:14
Copy link
Copy Markdown
Contributor

@dongoc dongoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dongoc
Copy link
Copy Markdown
Contributor

dongoc commented Mar 10, 2025

14는 아직 prod 검증이 완전하지 않은 버전이라 기능 추가여도 마이너 버전이 아니라 패치 버전을 올리는 걸로 알고 있어요!
(관련 대화 링크를 찾으려고 했는데 못 찾겠네요😂)

@dia-triple
Copy link
Copy Markdown
Contributor Author

14는 아직 prod 검증이 완전하지 않은 버전이라 기능 추가여도 마이너 버전이 아니라 패치 버전을 올리는 걸로 알고 있어요! (관련 대화 링크를 찾으려고 했는데 못 찾겠네요😂)

아!!! 감사합니다!!!

@dia-triple dia-triple modified the milestones: 14.1.0, 14.0.12 Mar 10, 2025
@dia-triple dia-triple merged commit d0336f7 into main Mar 14, 2025
11 of 12 checks passed
@dia-triple dia-triple deleted the feat/remove-triple-web-dependency branch March 14, 2025 02:25
@dia-triple dia-triple modified the milestones: 14.0.12, 14.0.13 Apr 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants