Skip to content

Conversation

@dongoc
Copy link
Contributor

@dongoc dongoc commented Jan 16, 2026

PR 설명

기존에 사용하던 @titicaca/intersection-observer 커스텀 패키지를 제거하고, react-intersection-observer 라이브러리로 교체합니다.

변경 이유

  • @titicaca/intersection-observer 패키지는 @titicaca/react-intersection-observerintersection-observer 폴리필을 감싸는 래퍼 패키지였습니다.
  • 현재 대부분의 브라우저에서 IntersectionObserver를 네이티브로 지원하므로 폴리필이 불필요해졌습니다.
  • react-intersection-observer는 더 활발히 유지보수되고, 더 간결한 API를 제공합니다.

변경 내역

1. @titicaca/intersection-observer 패키지 삭제

  • packages/intersection-observer/ 디렉토리 전체 삭제
  • README, package.json, 소스 코드, 설정 파일 등 모두 제거

2. 의존성 변경

  • tds-ui, tds-widget, triple-document 패키지에서 @titicaca/intersection-observer 의존성 제거
  • react-intersection-observer (^9.13.1) 의존성 추가

3. 컴포넌트 마이그레이션

react-intersection-observerInView 컴포넌트와 useInView 훅으로 교체:

4. 기타 변경

  • date-divider.tsx: chromatic-ignore 클래스 추가
  • day-picker.stories.tsx: Chromatic 스냅샷 비활성화 설정 추가

관련 문서

@dongoc dongoc added this to the v15.0.0 milestone Jan 16, 2026
@dongoc dongoc self-assigned this Jan 16, 2026
@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

❌ Patch coverage is 3.33333% with 58 lines in your changes missing coverage. Please review.
✅ Project coverage is 12.82%. Comparing base (4aa7484) to head (2e6e4d1).
⚠️ Report is 4 commits behind head on v15.

Files with missing lines Patch % Lines
...tds-widget/src/ad-banners/horizontal-list-view.tsx 0.00% 12 Missing ⚠️
...es/tds-widget/src/image-carousel/video-content.tsx 0.00% 7 Missing ⚠️
.../src/recommended-contents/recommended-contents.tsx 0.00% 7 Missing ⚠️
...c/review/components/review-element/media/video.tsx 0.00% 7 Missing ⚠️
...get/src/review/components/review-element/index.tsx 0.00% 3 Missing and 1 partial ⚠️
...ages/tds-ui/src/components/image/optimized-img.tsx 25.00% 2 Missing and 1 partial ⚠️
.../poi-detail/recommended-articles/article-entry.tsx 0.00% 3 Missing ⚠️
.../review/components/infinite-list/infinite-list.tsx 0.00% 2 Missing and 1 partial ⚠️
...s/tds-ui/src/components/carousel/carousel-item.tsx 33.33% 1 Missing and 1 partial ⚠️
...ages/tds-widget/src/ad-banners/vertical-entity.tsx 0.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##              v15    #3782      +/-   ##
==========================================
- Coverage   12.88%   12.82%   -0.07%     
==========================================
  Files         809      805       -4     
  Lines       11905    11861      -44     
  Branches     4153     4140      -13     
==========================================
- Hits         1534     1521      -13     
+ Misses       9877     9848      -29     
+ Partials      494      492       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dongoc dongoc force-pushed the NACS-869_delete/intersection-observer branch from bc68e43 to c47ab34 Compare January 19, 2026 23:11
@dongoc dongoc marked this pull request as ready for review January 20, 2026 00:05
@dongoc dongoc requested a review from a team as a code owner January 20, 2026 00:05
@dongoc dongoc requested review from guswl98, minsooyun and zhsks528 and removed request for a team January 20, 2026 00:05
@dongoc dongoc changed the base branch from main to v15 January 20, 2026 06:49
@dongoc
Copy link
Contributor Author

dongoc commented Jan 20, 2026

🙇‍♂️

@dongoc dongoc merged commit 3c0679d into v15 Jan 20, 2026
12 checks passed
@dongoc dongoc deleted the NACS-869_delete/intersection-observer branch January 20, 2026 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants