Skip to content

Commit 5ab64ec

Browse files
authored
Merge pull request #41 from amelie106/roman-scale
Enable minor scale in ChordRomanConverter
2 parents 2c1d0d8 + 108d4e0 commit 5ab64ec

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

src/chordparser/editors/chord_roman_converter.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,11 +83,12 @@ def to_roman(self, chord, scale_key):
8383
UserWarning
8484
)
8585
chord = self._CE.change_chord(chord, quality="Maj", inplace=False)
86+
8687
if isinstance(scale_key, Scale):
87-
scale_root = scale_key.key.root
88+
scale = scale_key
8889
else:
89-
scale_root = scale_key.root
90-
scale = self._SE.create_scale(scale_root, "major")
90+
scale = self._SE.create_scale(scale_key)
91+
9192
root = self._get_roman_root(chord, scale)
9293
quality = self._get_roman_quality(chord)
9394
inversion = self._get_roman_inversion(chord)

0 commit comments

Comments
 (0)