refactor: update to jquery 4.0.0

shrysjain · shrysjain · commit 564b304fc8a5 · 2026-04-09T13:35:44.000-04:00
diff --git a/intranet/static/js/announcement.form.js b/intranet/static/js/announcement.form.js
@@ -143,11 +143,11 @@ $(function() {
         exp.val(dateFormat(new Date($(this).data("date"))));
     });
 
-    $("#date-reset-btn").click(function () {
+    $("#date-reset-btn").on("click", function () {
         dateReset(exp);
     });
 
-    $("#no-expire-btn").click(function () {
+    $("#no-expire-btn").on("click", function () {
         date3000(exp);
     });
 });
diff --git a/intranet/static/js/dashboard/announcements.js b/intranet/static/js/dashboard/announcements.js
@@ -4,7 +4,7 @@ $(document).ready(function() {
 
     filterClubAnnouncements();
 
-    $(".club-announcements-header").click(function () {
+    $(".club-announcements-header").on("click", function () {
         let content = $(".club-announcements-content");
         if (!content.is(":visible")) {  // Avoid FOUC
             content.show();
@@ -15,24 +15,24 @@ $(document).ready(function() {
         $(".club-announcements-toggle-icon").toggleClass("fa-chevron-down fa-chevron-up");
     });
 
-    $(".announcement[data-id] h3").click(function (e) {
+    $(".announcement[data-id] h3").on("click", function (e) {
         if (e.target !== this) return;
         var btn = $(".announcement-toggle", $(this));
         announcementToggle.call(btn);
     });
 
-    $(".announcement[data-id] h3 .announcement-toggle").click(function (e) {
+    $(".announcement[data-id] h3 .announcement-toggle").on("click", function (e) {
         e.preventDefault();
         announcementToggle.call($(this));
     });
 
-    $(".announcement[data-id] h3 .dashboard-item-icon").click(function (e) {
+    $(".announcement[data-id] h3 .dashboard-item-icon").on("click", function (e) {
         e.preventDefault();
         var btn = $(".announcement-toggle", $(this).parent());
         announcementToggle.call(btn);
     });
 
-    $(window).resize(function () { setTimeout(updatePartiallyHidden, 0); });
+    $(window).on("resize", function () { setTimeout(updatePartiallyHidden, 0); });
 
     $("div[data-placeholder]").on("keydown keypress input", function () {
         if (this.textContent) {
diff --git a/intranet/static/js/eighth/distribute_group.js b/intranet/static/js/eighth/distribute_group.js
@@ -1,6 +1,6 @@
 /* global $ */
 $(function() {
-    $(".select-all").change(function() {
+    $(".select-all").on("change", function() {
         var chk = $(this).prop("checked");
         var name = $(this).attr("data-name");
         console.debug(chk, name);
@@ -12,7 +12,7 @@ $(function() {
         });
     });
 
-    $(".user-item").change(function() {
+    $(".user-item").on("change", function() {
         var chk = $(this).prop("checked");
         var name = $(this).attr("name");
         var num_checked = 0;
@@ -83,4 +83,4 @@ $(function() {
         msg += "\nTo apply these changes, press the Finish button below.";
         alert(msg);
     }
-});
+});
diff --git a/intranet/static/js/eighth/schedule.js b/intranet/static/js/eighth/schedule.js
@@ -34,7 +34,7 @@ $(function() {
         });
     });
 
-    $("select.remote-rooms").change(function(e) {
+    $("select.remote-rooms").on("change", function(e) {
         var $select = $(e.target);
 
         var capacitySum = 0;
diff --git a/intranet/static/js/eighth/signup.js b/intranet/static/js/eighth/signup.js
@@ -377,7 +377,7 @@ $(function() {
                         a.attributes.waitlisted = false;
                         a.attributes.waitlist_count -= 1;
                     });
-                    $(".current-day .block.active-block .block-letter").toggleClass("waitlist", true);
+                    $(".current-day .block.active-block .block-letter").addClass("waitlist");
                     window.currentWaitlist = activity.attributes.name;
                     activity.attributes.waitlist_count += 1;
                     activity.attributes.waitlist_position = activity.attributes.waitlist_count;
@@ -445,7 +445,7 @@ $(function() {
                     a.attributes.waitlisted = false;
                     a.attributes.waitlist_count -= 1;
                 });
-                $(".current-day .block.active-block .block-letter").toggleClass("waitlist", true);
+                $(".current-day .block.active-block .block-letter").addClass("waitlist");
                 window.currentWaitlist = activity.attributes.name;
                 activity.attributes.waitlist_count += 1;
                 activity.attributes.waitlist_position = activity.attributes.waitlist_count;
@@ -501,7 +501,7 @@ $(function() {
                 activity.attributes.waitlisted = false;
                 activity.attributes.waitlist_count -= 1;
                 activity.attributes.waitlist_position = 0;
-                $(".current-day .block.active-block .block-letter").toggleClass("waitlist", false);
+                $(".current-day .block.active-block .block-letter").removeClass("waitlist");
                 window.currentWaitlist = false;
 
                 activityDetailView.render();
diff --git a/intranet/static/js/eighth/user_link.js b/intranet/static/js/eighth/user_link.js
@@ -2,7 +2,7 @@
 $(function() {
     window.userHide = {};
 
-    $(".student-attendance-row").hover(function() {
+    $(".student-attendance-row").on("mouseenter", function() {
         var uid = $(this).children(".user-link[data-user-id]").attr("data-user-id");
 
         if (window.userHide.hasOwnProperty(uid)) {
@@ -19,14 +19,14 @@ $(function() {
         img.addClass("active");
         img.fadeIn(25);
 
-    }, function() {
+    }).on("mouseleave", function() {
         var uid = $(this).children(".user-link[data-user-id]").attr("data-user-id");
         window.userHide[uid] = setTimeout(function() {
             $(".user-pic[data-user-id='" + uid + "']").fadeOut(50).removeClass("active");
         }, 50);
     });
 
-    $(document).mousemove(function(e) {
+    $(document).on("mousemove", function(e) {
         var posx = window.mouseX = e.pageX,
             posy = window.mouseY = e.pageY;
         posx += 150;
@@ -42,4 +42,4 @@ $(function() {
             top: posy
         });
     });
-})
+})
diff --git a/intranet/static/js/login.js b/intranet/static/js/login.js
@@ -29,7 +29,7 @@ $(function() {
         }
     });
 
-    $(window).resize(function() {
+    $(window).on("resize", function() {
         if($(".sidebar").hasClass("has-events")){
             if($(this).width() > 800) {
                 $(".center-wrapper").removeClass("disable-interaction");
diff --git a/intranet/static/js/logs.js b/intranet/static/js/logs.js
@@ -18,7 +18,7 @@ $(function() {
     $(".pagination a").on("click", function () {
         goToPage($(this).attr("data-page"));
     });
-    $(".pagination form").submit(function (e) {
+    $(".pagination form").on("submit", function (e) {
         e.preventDefault();
         goToPage($(this).find("input").val());
     });
diff --git a/intranet/static/js/polls-vote.js b/intranet/static/js/polls-vote.js
@@ -24,7 +24,7 @@ $(function() {
         $(this.children[0]).text(!expanded ? "Expand All" : "Collapse All");
     });
 
-    $(".question-clear-action").change(function() {
+    $(".question-clear-action").on("change", function() {
         let chk = $(this).prop("checked");
         let ul = $(this).parent().parent();
 
diff --git a/intranet/static/js/polls.js b/intranet/static/js/polls.js
@@ -126,7 +126,7 @@ $(function() {
         file_reader.readAsText(file);
     });
 
-    $("#poll-form").submit(function() {
+    $("#poll-form").on("submit", function() {
         var out = [];
         $("#questions .question").each(function() {
             var q = {
diff --git a/intranet/templates/announcements/add_modify.html b/intranet/templates/announcements/add_modify.html
@@ -16,6 +16,7 @@
     <script src="{% static 'js/announcement.form.js' %}"></script>
     <script>
         $(function() {
+            var author = $("#id_author");
             {% if action == "add" %}
                 $("#id_update_added_date").parent().parent().remove()
                 author.attr("placeholder", "{{ user.full_name_nick|escape }}");
diff --git a/intranet/templates/eighth/admin/choose_roster_activities.html b/intranet/templates/eighth/admin/choose_roster_activities.html
@@ -14,7 +14,7 @@
 
     <script>
 $(function() {
-    $("input[type=checkbox].all").change(function() {
+    $("input[type=checkbox].all").on("change", function() {
         var chk = $(this).prop("checked");
         $(".choose-activities tbody input").each(function() {
             $(this).prop("checked", chk);
diff --git a/intranet/templates/eighth/admin/copy_form.html b/intranet/templates/eighth/admin/copy_form.html
@@ -14,7 +14,7 @@
     {{ block.super }}
     <script>
     $(document).ready(function() {
-        $("form").submit(function() {
+        $("form").on("submit", function() {
             $(this).find("button").prop("disabled", true).html("<i class='fas fa-cog fa-spin'></i> Importing...");
         });
         var block_selectize = $("#block-select")[0].selectize;
diff --git a/intranet/templates/eighth/admin/global_statistics.html b/intranet/templates/eighth/admin/global_statistics.html
@@ -22,7 +22,7 @@
     <script>
     $(document).ready(function() {
         var type = "csv";
-        $("#generate-form").submit(function(e) {
+        $("#generate-form").on("submit", function(e) {
             $(this).find("button").hide();
             $("#generate-status").html("<i class='fas fa-cog fa-spin'></i> Please wait, generating the " + type.toUpperCase() + " file for the " + $("#year option:selected").text()  + " school year...");
         });
diff --git a/intranet/templates/eighth/statistics.html b/intranet/templates/eighth/statistics.html
@@ -48,10 +48,10 @@
         var capacity = {{ capacity }};
 
         $(document).ready(function() {
-            $("#year").change(function() {
+            $("#year").on("change", function() {
                 window.location.href = location.protocol + "//" + location.host + location.pathname + "?year=" + encodeURIComponent($("#year").val());
             });
-            $("#future").change(function () {
+            $("#future").on("change", function () {
                 params = location.search;
                 params = params.slice(1).trim('&')
                                .replace(/^&+/g, '')
diff --git a/intranet/templates/enrichment/home.html b/intranet/templates/enrichment/home.html
@@ -13,6 +13,7 @@
     {% if not show_all and not classic %}
     <script>
         var view = "{{ view }}";
+        var todayId = "{{ week_data.today|default:''|escapejs }}";
 
         function setView(view_name){
             if(view_name == "month") {
@@ -24,12 +25,16 @@
 
             toggleTouchEvents(view_name);
             attendButtonListener();
-            $("#{{ week_data.today }}").attr("class", "today");
+            if (todayId) {
+                $("#" + todayId).attr("class", "today");
+            }
         }
 
         $(document).ready(function() {
             setView(view);
-            $("#{{ week_data.today }}").attr("class", "today");
+            if (todayId) {
+                $("#" + todayId).attr("class", "today");
+            }
 
             $("#month-button").on("click", function(e){
                 e.preventDefault();
diff --git a/intranet/templates/events/home.html b/intranet/templates/events/home.html
@@ -13,6 +13,7 @@
     {% if not show_all and not classic %}
     <script>
         var view = "{{ view }}";
+        var todayId = "{{ week_data.today|default:''|escapejs }}";
 
         function setView(view_name){
             if(view_name == "month") {
@@ -23,12 +24,16 @@
             }
 
             toggleTouchEvents(view_name);
-            $("#{{ week_data.today }}").attr("class", "today");
+            if (todayId) {
+                $("#" + todayId).attr("class", "today");
+            }
         }
 
         $(document).ready(function() {
             setView(view);
-            $("#{{ week_data.today }}").attr("class", "today");
+            if (todayId) {
+                $("#" + todayId).attr("class", "today");
+            }
 
             $("#month-button").on("click", function(e){
                 e.preventDefault();
diff --git a/intranet/templates/oauth2_provider/application_form.html b/intranet/templates/oauth2_provider/application_form.html
@@ -64,7 +64,7 @@
                 });
 
                 {# if client_type is public, remove the client_credentials option for authorization_grant_type #}
-                $("#id_client_type").change(function() {
+                $("#id_client_type").on("change", function() {
                     if ($("#id_client_type").val() == "public") {
                         $("#id_authorization_grant_type")[0].selectize.setValue("authorization-code");
                         $("#id_authorization_grant_type")[0].selectize.removeOption("client-credentials");
@@ -78,7 +78,7 @@
                 });
 
                 {# if authorization_grant_type is authorization_code, show redirect_uris #}
-                $("#id_authorization_grant_type").change(function() {
+                $("#id_authorization_grant_type").on("change", function() {
                     if ($("#id_authorization_grant_type").val() == "authorization-code") {
                         $("#id_oidc_enabled").parent().show();
                         $("#id_redirect_uris").attr("required", "required").parent().parent().slideDown();
@@ -90,7 +90,7 @@
                     }
                 });
 
-                $("form").submit(function(e) {
+                $("form").on("submit", function(e) {
                     {# Clear redirect_uris if authorization_grant_type is client_credentials #}
                     if (!$("#id_redirect_uris").attr("required")) {
                         $("#id_redirect_uris").val("");
diff --git a/intranet/templates/oauth2_provider/application_registration_form.html b/intranet/templates/oauth2_provider/application_registration_form.html
@@ -86,7 +86,7 @@
                 }
 
                 {# If client_type is public, hide client_secret and remove the client_credentials option for authorization_grant_type #}
-                $("#id_client_type").change(function() {
+                $("#id_client_type").on("change", function() {
                     if ($("#id_client_type").val() == "public") {
                         $("#id_client_secret").parent().parent().slideUp();
                         $("#id_authorization_grant_type")[0].selectize.setValue("authorization-code");
@@ -115,7 +115,7 @@
                 });
 
                 {# If authorization_grant_type is authorization_code, show redirect_uris #}
-                $("#id_authorization_grant_type").change(function() {
+                $("#id_authorization_grant_type").on("change", function() {
                     if ($("#id_authorization_grant_type").val() == "authorization-code") {
                         $("#id_oidc_enabled").parent().show();
                         $("#id_redirect_uris").attr("required", "required").parent().parent().slideDown();
@@ -127,7 +127,7 @@
                     }
                 });
 
-                $("form").submit(function(e) {
+                $("form").on("submit", function(e) {
                     {# Check for AUP confirmation #}
                     if (!$("#accept-aup").is(":checked")) {
                         alert("You must agree to the Ion API and OAuth Acceptable Use Policy to create an OAuth application.");
diff --git a/intranet/templates/oauth2_provider/base.html b/intranet/templates/oauth2_provider/base.html
@@ -19,7 +19,8 @@
         {% stylesheet 'oauth' %}
     {% endblock %}
     {% block js %}
-        <script src="https://code.jquery.com/jquery-3.7.1.min.js"></script>
+        <script src="https://code.jquery.com/jquery-4.0.0.min.js"></script>
+        <script src="https://code.jquery.com/jquery-migrate-4.0.2.min.js"></script>
     {% endblock %}
     {% if dark_mode_enabled %}
         {% stylesheet 'dark/base' %}
diff --git a/intranet/templates/page_base.html b/intranet/templates/page_base.html
@@ -36,7 +36,8 @@
         {% endif %}
 
     {% block js %}
-        <script src="https://code.jquery.com/jquery-3.7.1.min.js"></script>
+        <script src="https://code.jquery.com/jquery-4.0.0.min.js"></script>
+        <script src="https://code.jquery.com/jquery-migrate-4.0.2.min.js"></script>
         <script src="{% static 'js/vendor/js.cookie.min.js' %}"></script>
         <script src="{% static 'js/vendor/modernizr.js' %}"></script>
         <script src="{% static 'js/common.js' %}"></script>
diff --git a/intranet/templates/polls/vote.html b/intranet/templates/polls/vote.html
@@ -26,7 +26,7 @@
     <script src={% static 'js/polls-vote.js' %}></script>
     <script>
     $(function() {
-        $(".question-clear-action").change(function() {
+        $(".question-clear-action").on("change", function() {
             var chk = $(this).prop("checked");
             var ul = $(this).parent().parent();
 
@@ -58,7 +58,7 @@
             {% endif %}
         {% endfor %}
 
-        $("form").submit(function(e) {
+        $("form").on("submit", function(e) {
             var errorContainer = $("#error-container");
             errorContainer.hide("fast");
 
@@ -370,4 +370,4 @@ <h2>Vote: {{ poll }}</h2>
         </form>
     </div>
 
-{% endblock %}
+{% endblock %}
diff --git a/intranet/templates/schedule/calendar.html b/intranet/templates/schedule/calendar.html
@@ -13,12 +13,15 @@
     <script src="{% static 'js/login.js' %}"></script>
     <script>
         var view = "{{ view }}";
+        var todayId = "{{ day.sched_ctx.date|default:''|escapejs }}";
         function setView(view_name){
             if(view_name == "month") $("#view-div").html(`{% include "schedule/month.html" %}`);
             else                     $("#view-div").html(`{% include "schedule/week.html" %}`);
 
             toggleTouchEvents(view_name);
-            $("#{{ day.sched_ctx.date }}").attr("class", "today");
+            if (todayId) {
+                $("#" + todayId).attr("class", "today");
+            }
         }
         $(document).ready(function() {
             setView(view);
diff --git a/intranet/templates/schedule/embed.html b/intranet/templates/schedule/embed.html
diff --git a/intranet/templates/schedule/week_view.html b/intranet/templates/schedule/week_view.html
diff --git a/intranet/templates/signage/base.html b/intranet/templates/signage/base.html
diff --git a/intranet/templates/signage/pages/eighth.html b/intranet/templates/signage/pages/eighth.html
diff --git a/intranet/templates/users/profile.html b/intranet/templates/users/profile.html

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ $(function() {`
`29`	`29`	`}`
`30`	`30`	`});`
`31`	`31`
`32`		`- $(window).resize(function() {`
	`32`	`+ $(window).on("resize", function() {`
`33`	`33`	`if($(".sidebar").hasClass("has-events")){`
`34`	`34`	`if($(this).width() > 800) {`
`35`	`35`	`$(".center-wrapper").removeClass("disable-interaction");`