Handle binary files when importing assignments (#109)

Author: JasonGrace2282

tin/apps/assignments/models.py

@@ -336,7 +336,7 @@ def list_files(self) -> list[tuple[int, str, str, int, datetime.datetime]]:
 
         return files
 
-    def save_file(self, file_text: str, file_name: str) -> None:
+    def save_file(self, file_text: str | bytes, file_name: str) -> None:
         """Save some text as a file"""
         self.make_assignment_dir()
 
@@ -349,16 +349,19 @@ def save_file(self, file_text: str, file_name: str) -> None:
             network_access=False,
             whitelist=[os.path.dirname(fpath)],
         )
+        kwargs = {}
+        if isinstance(file_text, str):
+            kwargs["text"] = True
+            kwargs["encoding"] = "utf-8"
 
         try:
             subprocess.run(
                 args,
                 input=file_text,
                 stdout=subprocess.DEVNULL,
                 stderr=subprocess.PIPE,
-                encoding="utf-8",
-                text=True,
                 check=True,
+                **kwargs,
             )
         except FileNotFoundError as e:
             logger.error("Cannot run processes: %s", e)

tin/apps/courses/views.py

@@ -1,6 +1,7 @@
 from __future__ import annotations
 
 from datetime import date, timedelta
+from pathlib import Path
 
 from django.shortcuts import get_object_or_404, redirect, render
 from django.utils import timezone
@@ -235,8 +236,8 @@ def import_from_selected_course(request, course_id, other_course_id):
 
                 if form.cleaned_data["copy_files"]:
                     for _, filename, path, _, _ in old_assignment.list_files():
-                        with open(path) as f:
-                            assignment.save_file(f.read(), filename)
+                        content = Path(path).read_bytes()
+                        assignment.save_file(content, filename)
 
             return redirect("courses:show", course.id)
     else: